Drawing fake bold text, line and normal text made normal text bolder on PDF.

src/pdf/SkPDFDevice.cpp

Index: src/pdf/SkPDFDevice.cpp
diff --git a/src/pdf/SkPDFDevice.cpp b/src/pdf/SkPDFDevice.cpp
index ff83aadeee7b8a27b71b52542625947553dbb8a2..773928b5344371448160f0f23fb4925bcc561aae 100644
--- a/src/pdf/SkPDFDevice.cpp
+++ b/src/pdf/SkPDFDevice.cpp
@@ -238,9 +238,8 @@ bool GraphicStateEntry::compareInitialState(const GraphicStateEntry& b) {
            fGraphicStateIndex == b.fGraphicStateIndex &&
            fMatrix == b.fMatrix &&
            fClipStack == b.fClipStack &&
-               (fTextScaleX == 0 ||
-                b.fTextScaleX == 0 ||
-                (fTextScaleX == b.fTextScaleX && fTextFill == b.fTextFill));
+           fTextScaleX == b.fTextScaleX &&

[vandebo (ex-Chrome), 2014/02/05 22:07:08]

This will work, but I think it's a bit more specific than we need to be.

Being more specific requires knowing which entry is the current one, and which
one is the previous, which is fine - there's only one caller to this function =>
 Rename b to cur.  Then if the new entry doesn't care about text (i.e.
fTextScaleX == 0), we're ok, but if the new entry does care, it has to match
both.  So 241-242 becomes:
(fTextScaleX == 0 ||
 (fTextScaleX == cur.fTextScaleX && fTextFill == cur.fTextFill));

Sound right/work for you?

+           (!fTextScaleX || fTextFill == b.fTextFill);
 }
 
 class GraphicStackState {