Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Side by Side Diff: content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc

Issue 137923003: Change fileapi namespace to content for files that are moved under content/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: build fix Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/browser/fileapi/sandbox_file_system_backend_delegate.h" 5 #include "webkit/browser/fileapi/sandbox_file_system_backend_delegate.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
12 #include "base/message_loop/message_loop_proxy.h" 12 #include "base/message_loop/message_loop_proxy.h"
13 #include "content/public/test/test_file_system_options.h" 13 #include "content/public/test/test_file_system_options.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "url/gurl.h" 15 #include "url/gurl.h"
16 #include "webkit/browser/fileapi/file_system_url.h" 16 #include "webkit/browser/fileapi/file_system_url.h"
17 17
18 namespace fileapi { 18 using fileapi::FileSystemURL;
19
20 namespace content {
19 21
20 namespace { 22 namespace {
21 23
22 FileSystemURL CreateFileSystemURL(const char* path) { 24 FileSystemURL CreateFileSystemURL(const char* path) {
23 const GURL kOrigin("http://foo/"); 25 const GURL kOrigin("http://foo/");
24 return FileSystemURL::CreateForTest( 26 return fileapi::FileSystemURL::CreateForTest(
25 kOrigin, kFileSystemTypeTemporary, base::FilePath::FromUTF8Unsafe(path)); 27 kOrigin, fileapi::kFileSystemTypeTemporary,
28 base::FilePath::FromUTF8Unsafe(path));
26 } 29 }
27 30
28 } // namespace 31 } // namespace
29 32
30 class SandboxFileSystemBackendDelegateTest : public testing::Test { 33 class SandboxFileSystemBackendDelegateTest : public testing::Test {
31 protected: 34 protected:
32 virtual void SetUp() { 35 virtual void SetUp() {
33 ASSERT_TRUE(data_dir_.CreateUniqueTempDir()); 36 ASSERT_TRUE(data_dir_.CreateUniqueTempDir());
34 delegate_.reset(new SandboxFileSystemBackendDelegate( 37 delegate_.reset(new fileapi::SandboxFileSystemBackendDelegate(
35 NULL /* quota_manager_proxy */, 38 NULL /* quota_manager_proxy */,
36 base::MessageLoopProxy::current().get(), 39 base::MessageLoopProxy::current().get(),
37 data_dir_.path(), 40 data_dir_.path(),
38 NULL /* special_storage_policy */, 41 NULL /* special_storage_policy */,
39 CreateAllowFileAccessOptions())); 42 CreateAllowFileAccessOptions()));
40 } 43 }
41 44
45 bool IsAccessValid(const FileSystemURL& url) const {
46 return delegate_->IsAccessValid(url);
47 }
48
42 base::ScopedTempDir data_dir_; 49 base::ScopedTempDir data_dir_;
43 base::MessageLoop message_loop_; 50 base::MessageLoop message_loop_;
44 scoped_ptr<SandboxFileSystemBackendDelegate> delegate_; 51 scoped_ptr<fileapi::SandboxFileSystemBackendDelegate> delegate_;
45 }; 52 };
46 53
47 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) { 54 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) {
48 // Normal case. 55 // Normal case.
49 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL("a"))); 56 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("a")));
50 57
51 // Access to a path with parent references ('..') should be disallowed. 58 // Access to a path with parent references ('..') should be disallowed.
52 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL("a/../b"))); 59 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("a/../b")));
53 60
54 // Access from non-allowed scheme should be disallowed. 61 // Access from non-allowed scheme should be disallowed.
55 EXPECT_FALSE(delegate_->IsAccessValid( 62 EXPECT_FALSE(IsAccessValid(
56 FileSystemURL::CreateForTest( 63 FileSystemURL::CreateForTest(
57 GURL("unknown://bar"), kFileSystemTypeTemporary, 64 GURL("unknown://bar"), fileapi::kFileSystemTypeTemporary,
58 base::FilePath::FromUTF8Unsafe("foo")))); 65 base::FilePath::FromUTF8Unsafe("foo"))));
59 66
60 // Access with restricted name should be disallowed. 67 // Access with restricted name should be disallowed.
61 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL("."))); 68 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".")));
62 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL(".."))); 69 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("..")));
63 70
64 // This is also disallowed due to Windows XP parent path handling. 71 // This is also disallowed due to Windows XP parent path handling.
65 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL("..."))); 72 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("...")));
66 73
67 // These are identified as unsafe cases due to weird path handling 74 // These are identified as unsafe cases due to weird path handling
68 // on Windows. 75 // on Windows.
69 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL(" .."))); 76 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(" ..")));
70 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL(".. "))); 77 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".. ")));
71 78
72 // Similar but safe cases. 79 // Similar but safe cases.
73 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL(" ."))); 80 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(" .")));
74 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL(". "))); 81 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(". ")));
75 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL("b."))); 82 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("b.")));
76 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL(".b"))); 83 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(".b")));
77 84
78 // A path that looks like a drive letter. 85 // A path that looks like a drive letter.
79 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL("c:"))); 86 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("c:")));
80 } 87 }
81 88
82 } // namespace fileapi 89 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698