Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 137923002: Update more modules/ classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, kinuko, Raymond Toy, Inactive, timvolodine, Michael van Ouwerkerk
Visibility:
Public.

Description

Update more modules/ classes to use OVERRIDE / FINAL when needed Update more modules/ classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. These were found using the chromium style clang plugin. R=eseidel, abarth BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165410

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/modules/device_orientation/DeviceMotionEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DraggedIsolatedFileSystem.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/Geolocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/BiquadProcessor.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Inactive
6 years, 11 months ago (2014-01-14 07:18:10 UTC) #1
Inactive
ping review?
6 years, 11 months ago (2014-01-17 18:53:17 UTC) #2
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-18 08:57:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137923002/1
6 years, 11 months ago (2014-01-18 08:57:52 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/modules/filesystem/DraggedIsolatedFileSystem.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-18 08:57:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137923002/110001
6 years, 11 months ago (2014-01-18 15:16:41 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18079
6 years, 11 months ago (2014-01-18 15:48:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137923002/110001
6 years, 11 months ago (2014-01-18 16:26:46 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18087
6 years, 11 months ago (2014-01-18 16:52:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137923002/110001
6 years, 11 months ago (2014-01-18 18:26:57 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18096
6 years, 11 months ago (2014-01-18 18:58:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137923002/110001
6 years, 11 months ago (2014-01-19 03:41:02 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18102
6 years, 11 months ago (2014-01-19 04:03:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137923002/110001
6 years, 11 months ago (2014-01-19 21:23:59 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18108
6 years, 11 months ago (2014-01-19 21:43:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137923002/110001
6 years, 11 months ago (2014-01-20 14:04:27 UTC) #16
commit-bot: I haz the power
6 years, 11 months ago (2014-01-20 14:57:00 UTC) #17
Message was sent while issue was closed.
Change committed as 165410

Powered by Google App Engine
This is Rietveld 408576698