Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.h

Issue 1379213002: Remove LayoutTable::m_currentBorder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTable.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.h b/third_party/WebKit/Source/core/layout/LayoutTable.h
index 84ac080ddffdc1bca7166150633991862a94b6ac..4c0bc03898077fe420c74084746e85f7c00ba4bd 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTable.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTable.h
@@ -304,10 +304,6 @@ public:
typedef Vector<CollapsedBorderValue> CollapsedBorderValues;
void invalidateCollapsedBorders();
- // TODO(wangxianzhu): This method should be moved into TablePainter.
- const CollapsedBorderValue* currentBorderValue() const { return m_currentBorder; }
- void setCurrentBorderValue(const CollapsedBorderValue* val) const { m_currentBorder = val; }
-
bool hasSections() const { return m_head || m_foot || m_firstBody; }
void recalcSectionsIfNeeded() const
@@ -384,9 +380,9 @@ private:
void recalcCollapsedBordersIfNeeded();
- // TODO(layout-dev): All mutables in this class (except for m_currentBorder) are lazily updated by recalcSections()
- // which is called by various getter methods (e.g. borderBefore(), borderAfter()). They allow dirty layout even after
- // DocumentLifecycle::LayoutClean which seems not proper. crbug.com/538236.
+ // TODO(layout-dev): All mutables in this class are lazily updated by recalcSections()
+ // which is called by various getter methods (e.g. borderBefore(), borderAfter()).
+ // They allow dirty layout even after DocumentLifecycle::LayoutClean which seems not proper. crbug.com/538236.
mutable Vector<int> m_columnPos;
@@ -439,9 +435,6 @@ private:
// A sorted list of all unique border values that we want to paint.
CollapsedBorderValues m_collapsedBorders;
- // Used by TablePainter during painting.
- // TODO(wangxianzhu): Move it into painter.
- mutable const CollapsedBorderValue* m_currentBorder;
bool m_collapsedBordersValid : 1;
mutable bool m_hasColElements : 1;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698