Switch ComponentCloudPolicyUpdater to ExternalPolicyDataUpdater backend

Switch ComponentCloudPolicyUpdater to ExternalPolicyDataUpdater backend

This CL makes the ComponentCloudPolicyUpdater class use a
ExternalPolicyDataUpdater as its backend, removing code duplicated between
the two classes and completing the refactor that makes
ExternalPolicyDataUpdater available for other consumers.

BUG=152957, 220418, 225960
TEST=unittests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193417

[bartfab (slow), 2013-04-08 12:54:09]

Hi Joao,

Could you take a look?

[Joao da Silva, 2013-04-08 14:49:40]

lgtm

https://codereview.chromium.org/13792003/diff/1/chrome/browser/policy/cloud/c...
File chrome/browser/policy/cloud/component_cloud_policy_updater.cc (right):

https://codereview.chromium.org/13792003/diff/1/chrome/browser/policy/cloud/c...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:39:
external_policy_data_updater_(task_runner, request_context, 1) {
Come to think of it, I guess 2 or 3 parallel downloads should be fine.

https://codereview.chromium.org/13792003/diff/1/chrome/browser/policy/cloud/c...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:44: 
nit: remove this newline

https://codereview.chromium.org/13792003/diff/1/chrome/browser/policy/cloud/c...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:62: const
std::string cached_hash = store_->GetCachedHash(ns);
This can be a const ref

https://codereview.chromium.org/13792003/diff/1/chrome/browser/policy/cloud/c...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:94:
data.secure_hash()));
Super cool that this works :-)

https://codereview.chromium.org/13792003/diff/1/chrome/browser/policy/cloud/c...
File chrome/browser/policy/cloud/component_cloud_policy_updater.h (left):

https://codereview.chromium.org/13792003/diff/1/chrome/browser/policy/cloud/c...
chrome/browser/policy/cloud/component_cloud_policy_updater.h:50:
~ComponentCloudPolicyUpdater();
Please leave this, even if the impl is empty.

[bartfab (slow), 2013-04-08 15:32:12]

https://chromiumcodereview.appspot.com/13792003/diff/1/chrome/browser/policy/...
File chrome/browser/policy/cloud/component_cloud_policy_updater.cc (right):

https://chromiumcodereview.appspot.com/13792003/diff/1/chrome/browser/policy/...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:39:
external_policy_data_updater_(task_runner, request_context, 1) {
On 2013/04/08 14:49:40, Joao da Silva wrote:
> Come to think of it, I guess 2 or 3 parallel downloads should be fine.

Done. Updated the tests accordingly as well.

https://chromiumcodereview.appspot.com/13792003/diff/1/chrome/browser/policy/...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:44: 
On 2013/04/08 14:49:40, Joao da Silva wrote:
> nit: remove this newline

Done.

https://chromiumcodereview.appspot.com/13792003/diff/1/chrome/browser/policy/...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:62: const
std::string cached_hash = store_->GetCachedHash(ns);
On 2013/04/08 14:49:40, Joao da Silva wrote:
> This can be a const ref

Done.

https://chromiumcodereview.appspot.com/13792003/diff/1/chrome/browser/policy/...
chrome/browser/policy/cloud/component_cloud_policy_updater.cc:94:
data.secure_hash()));
On 2013/04/08 14:49:40, Joao da Silva wrote:
> Super cool that this works :-)

That's why I fixed the other CL to use a "const std::string&" argument, making
the two compatible :).

https://chromiumcodereview.appspot.com/13792003/diff/1/chrome/browser/policy/...
File chrome/browser/policy/cloud/component_cloud_policy_updater.h (left):

https://chromiumcodereview.appspot.com/13792003/diff/1/chrome/browser/policy/...
chrome/browser/policy/cloud/component_cloud_policy_updater.h:50:
~ComponentCloudPolicyUpdater();
On 2013/04/08 14:49:40, Joao da Silva wrote:
> Please leave this, even if the impl is empty.

Done.

[commit-bot: I haz the power, 2013-04-09 16:11:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/13792003/5001

[commit-bot: I haz the power, 2013-04-09 16:38:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-10 11:05:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/13792003/19001

[commit-bot: I haz the power, 2013-04-10 11:07:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/13792003/27002

[commit-bot: I haz the power, 2013-04-10 15:06:34]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-10 16:08:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/13792003/27002

[commit-bot: I haz the power, 2013-04-10 17:57:32]

Change committed as 193417