Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/core/rendering/RenderDialog.cpp

Issue 13792002: Fix <dialog> centering (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderDialog.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 *
8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution.
13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25
26 #include "config.h"
27 #include "RenderDialog.h"
28
29 #if ENABLE(DIALOG_ELEMENT)
30 #include "FrameView.h"
31 #include "LayoutRepainter.h"
32 #include "RenderLayer.h"
33 #include "RenderView.h"
34
35 namespace WebCore {
36
37 void RenderDialog::layout()
38 {
39 StackStats::LayoutCheckPoint layoutCheckPoint;
40 LayoutRepainter repainter(*this, true);
41 LayoutStateMaintainer statePusher(view(), this, locationOffset(), hasTransfo rm() || hasReflection() || style()->isFlippedBlocksWritingMode());
42
43 RenderBlock::layout();
44
45 RenderStyle* styleToUse = style();
46 if (styleToUse->position() != AbsolutePosition || !styleToUse->top().isAuto( ) || !styleToUse->bottom().isAuto()) {
47 statePusher.pop();
48 return;
49 }
50
51 // Adjust the dialog's position to be centered in or at the top of the viewp ort.
52 // FIXME: Figure out what to do in vertical writing mode.
53 FrameView* frameView = document()->view();
54 int scrollTop = frameView->scrollOffset().height();
55 FloatPoint absolutePoint(0, scrollTop);
56 int visibleHeight = frameView->visibleContentRect(ScrollableArea::IncludeScr ollbars).height();
57 if (height() < visibleHeight)
58 absolutePoint.move(0, (visibleHeight - height()) / 2);
59 FloatPoint localPoint = containingBlock()->absoluteToLocal(absolutePoint);
60 LayoutUnit localTop = LayoutSize(localPoint.x(), localPoint.y()).height();
61 setY(localTop);
62
63 statePusher.pop();
64 // FIXME: Since there is always a layer here, repainter shouldn't be necessa ry. But without it, the dialog is sometimes not painted (see bug 90670).
65 repainter.repaintAfterLayout();
66 }
67
68 }
69
70 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderDialog.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698