chrome/android/java/res/layout/contextual_search_peek_promo.xml - Issue 1379183003: [ContextualSearch] Adds long press promo for Contextual Search.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/contextual_search_peek_promo.xml

Issue 1379183003: [ContextualSearch] Adds long press promo for Contextual Search. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Aurimas's comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable/contextual_search_peek_promo_new_background.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2015 The Chromium Authors. All rights reserved.

	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:id="@+id/contextual_search_peek_promo"

	10 android:layout_width="match_parent"

	11 android:layout_height="@dimen/contextual_search_peek_promo_height"

	12 android:orientation="horizontal"

	13 android:paddingStart="@dimen/contextual_search_peek_promo_padding"

	14 android:paddingEnd="@dimen/contextual_search_peek_promo_padding"

	15 android:textSize="14sp">
	aurimas (slooooooooow) 2015/10/03 00:54:02 Does android:textSize on a linear layout set the t Does android:textSize on a linear layout set the text size for both the TextView inside of it? I've never seen it used that way. pedro (no code reviews) 2015/10/05 02:13:21 You're right. Moved declaration to each TextView. Show quoted text On 2015/10/03 00:54:02, aurimas wrote: > Does android:textSize on a linear layout set the text size for both the TextView > inside of it? I've never seen it used that way. You're right. Moved declaration to each TextView.
	16 <TextView

	17 android:id="@+id/contextual_search_peek_promo_new"

	18 android:layout_width="wrap_content"

	19 android:layout_height="wrap_content"

	20 android:layout_marginEnd="@dimen/contextual_search_peek_promo_padding"

	21 android:background="@drawable/contextual_search_peek_promo_new_backgroun d"

	22 android:text="@string/contextual_search_peek_promo_new"

	23 android:textAllCaps="true"

	24 android:textColor="@color/light_active_color"

	25 />

	26 <!-- TODO(pedrosimonetti): Find a better layout for handling multiline text -->

	27 <TextView

	28 android:id="@+id/contextual_search_peek_promo_text"

	29 android:layout_width="wrap_content"

	30 android:layout_height="wrap_content"

	31 android:text="@string/contextual_search_peek_promo_text"

	32 android:textColor="#FFF"

	33 />

	34 </LinearLayout>

OLD	NEW