Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: pkg/analysis_server/test/analysis/notification_implemented_test.dart

Issue 1379153002: pkg: Eliminate flaky analysis test failure. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: added timeout, changed polling interval to 1ms Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis/notification_implemented_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_implemented_test.dart b/pkg/analysis_server/test/analysis/notification_implemented_test.dart
index 9f96762d389420545a4a6f7933b6add41e7bb829..5898daf4ee5ca4d14e36c04db9ec10df9928ff9f 100644
--- a/pkg/analysis_server/test/analysis/notification_implemented_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_implemented_test.dart
@@ -312,8 +312,8 @@ class B extends A {
return new Future.value();
}
return new Future.delayed(
- Duration.ZERO, () => waitForNotification(times - 1));
+ new Duration(milliseconds:1), () => waitForNotification(times - 1));
}
- return waitForNotification(100);
+ return waitForNotification(30000);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698