themes: Remove usage of TOOLKIT_GTK define.

themes: Remove usage of TOOLKIT_GTK define.

This define is not defined anymore, so this patch removes its usage.

BUG=None
R=pkotwicz@chromium.org

Committed: https://crrev.com/f5e604fdf3306c8aec968a28a8b6c93be32dd814
Cr-Commit-Position: refs/heads/master@{#356613}

[tfarina, 2015-10-05 23:32:03]

PTAL

https://codereview.chromium.org/1379133004/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_syncable_service_unittest.cc (right):

https://codereview.chromium.org/1379133004/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_syncable_service_unittest.cc:572:
DISABLED_GtkUpdateSystemThemeBitWhenChangeBetweenSystemAndDefault) {
Is this OK? I was not sure what to use instead.

[pkotwicz, 2015-10-06 16:56:34]

https://codereview.chromium.org/1379133004/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_syncable_service_unittest.cc (right):

https://codereview.chromium.org/1379133004/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_syncable_service_unittest.cc:57: class
FakeThemeService : public ThemeService {
FakeThemeService should override
ThemeService::IsSystemThemeDistinctFromDefaultTheme() and provide a way for
tests to set the returned value.
(ThemeServiceAuraX11::::IsSystemThemeDistinctFromDefaultTheme() returns true)

Both of tests: GtkUpdateSystemThemeBitWhenChangeBetweenSystemAndDefault and
NonGtkPreserveSystemThemeBitWhenChangeToDefaultTheme should be enabled all of
the time given that the tests can just set the return value of
ThemeService::IsSystemThemeDistinctFromDefaultTheme().

I would recommend renaming the tests:
GtkUpdateSystemThemeBitWhenChangeBetweenSystemAndDefault -> DistinctSystemTheme
NonGtkPreserveSystemThemeBitWhenChangeToDefaultTheme->
SystemThemeSameAsDefaultTheme

[tfarina, 2015-10-13 15:15:58]

Sorry for the delay Peter, I have been working on other things.

I will try to build and test this later today.

[tfarina, 2015-10-25 02:43:25]

Peter, I finally found some time to work on this, this weekend.

Please, take another look.

Thanks,

https://codereview.chromium.org/1379133004/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_syncable_service_unittest.cc (right):

https://codereview.chromium.org/1379133004/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_syncable_service_unittest.cc:57: class
FakeThemeService : public ThemeService {
On 2015/10/06 16:56:34, pkotwicz wrote:
> FakeThemeService should override
> ThemeService::IsSystemThemeDistinctFromDefaultTheme() and provide a way for
> tests to set the returned value.
> (ThemeServiceAuraX11::::IsSystemThemeDistinctFromDefaultTheme() returns true)
> 
> Both of tests: GtkUpdateSystemThemeBitWhenChangeBetweenSystemAndDefault and
> NonGtkPreserveSystemThemeBitWhenChangeToDefaultTheme should be enabled all of
> the time given that the tests can just set the return value of
> ThemeService::IsSystemThemeDistinctFromDefaultTheme().
> 
> I would recommend renaming the tests:
> GtkUpdateSystemThemeBitWhenChangeBetweenSystemAndDefault ->
DistinctSystemTheme
> NonGtkPreserveSystemThemeBitWhenChangeToDefaultTheme->
> SystemThemeSameAsDefaultTheme

Done.

[pkotwicz, 2015-10-28 15:02:12]

LGTM

Sorry about the delay

https://codereview.chromium.org/1379133004/diff/40001/chrome/browser/themes/t...
File chrome/browser/themes/theme_syncable_service_unittest.cc (right):

https://codereview.chromium.org/1379133004/diff/40001/chrome/browser/themes/t...
chrome/browser/themes/theme_syncable_service_unittest.cc:90: }
Nit: New line

[tfarina, 2015-10-28 18:55:13]

https://codereview.chromium.org/1379133004/diff/40001/chrome/browser/themes/t...
File chrome/browser/themes/theme_syncable_service_unittest.cc (right):

https://codereview.chromium.org/1379133004/diff/40001/chrome/browser/themes/t...
chrome/browser/themes/theme_syncable_service_unittest.cc:90: }
On 2015/10/28 15:02:11, pkotwicz wrote:
> Nit: New line

Done.

[tfarina, 2015-10-28 18:56:20]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-28 18:56:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/1379133004/#ps60001
(title: "\n")

[commit-bot: I haz the power, 2015-10-28 18:57:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1379133004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1379133004/60001

[commit-bot: I haz the power, 2015-10-28 19:30:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-28 19:31:36]

Patchset 4 (id:??) landed as
https://crrev.com/f5e604fdf3306c8aec968a28a8b6c93be32dd814
Cr-Commit-Position: refs/heads/master@{#356613}