Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1379133003: Revert of Enable the bootstrap sandbox by default. (Closed)

Created:
5 years, 2 months ago by Robert Sesek
Modified:
5 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, Mark Mentovai
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable the bootstrap sandbox by default. (patchset #1 id:1 of https://codereview.chromium.org/1372343004/ ) Reason for revert: Caused performance regressions: https://crbug.com/537680 Original issue's description: > Reland of Enable the bootstrap sandbox by default. (patchset #1 id:1 of https://codereview.chromium.org/1355043004/ ) > > Reason for revert: > Fixed issue that was the cause of the revert, https://crbug.com/534650. > > Original issue's description: > > Revert of Enable the bootstrap sandbox by default. (patchset #3 id:40001 of https://codereview.chromium.org/1352623003/ ) > > > > Reason for revert: > > Caused Mac 10.10 layout failures: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/4593 > > > > Original issue's description: > > > Enable the bootstrap sandbox by default. > > > > > > This will place renderer processes under the bootstrap sandbox. This can be > > > disabled with --disable-bootstrap-sandbox. > > > > > > BUG=367863 > > > > > > Committed: https://crrev.com/2dded5291bc5e9427721e1a06c74f2a80a86e8fa > > > Cr-Commit-Position: refs/heads/master@{#350006} > > > > TBR=avi@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=367863 > > > > Committed: https://crrev.com/f1422520b42e8fa5b4ffe75359af96bac75d67b0 > > Cr-Commit-Position: refs/heads/master@{#350065} > > TBR=avi@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=367863 > > Committed: https://crrev.com/be226728db60e5860ab8d775eae36e406a41d7ee > Cr-Commit-Position: refs/heads/master@{#351386} TBR=avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=367863 Committed: https://crrev.com/ce0bd3344168be0edc385c02cb7f0ef393540a1a Cr-Commit-Position: refs/heads/master@{#351809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M content/browser/bootstrap_sandbox_manager_mac.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
Created Revert of Enable the bootstrap sandbox by default.
5 years, 2 months ago (2015-10-01 15:19:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379133003/1
5 years, 2 months ago (2015-10-01 15:20:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 15:21:04 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 15:21:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce0bd3344168be0edc385c02cb7f0ef393540a1a
Cr-Commit-Position: refs/heads/master@{#351809}

Powered by Google App Engine
This is Rietveld 408576698