Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Issue 1379093002: [Interpreter]: Add ignition variant to test runner. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Add ignition variant to test runner. Adds an ignition variant to the test runner and adds support to test262 for filtering such that only test scripts (not the test harness) get run by the interpreter. BUG=v8:4280 LOG=N Committed: https://crrev.com/6ff9516b45340e296dfb949f35ea5349deb2744b Cr-Commit-Position: refs/heads/master@{#31123}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M test/test262/testcfg.py View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379093002/20001
5 years, 2 months ago (2015-10-01 07:29:34 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 07:55:06 UTC) #4
rmcilroy
Michael, could you take a look please, thanks.
5 years, 2 months ago (2015-10-01 08:14:50 UTC) #6
Michael Achenbach
lgtm https://codereview.chromium.org/1379093002/diff/20001/test/test262/testcfg.py File test/test262/testcfg.py (right): https://codereview.chromium.org/1379093002/diff/20001/test/test262/testcfg.py#newcode133 test/test262/testcfg.py:133: ignition_filter = "--ignition-filter=" + self.testroot + "/*" Please ...
5 years, 2 months ago (2015-10-01 08:44:53 UTC) #8
rmcilroy
https://codereview.chromium.org/1379093002/diff/20001/test/test262/testcfg.py File test/test262/testcfg.py (right): https://codereview.chromium.org/1379093002/diff/20001/test/test262/testcfg.py#newcode133 test/test262/testcfg.py:133: ignition_filter = "--ignition-filter=" + self.testroot + "/*" On 2015/10/01 ...
5 years, 2 months ago (2015-10-06 12:43:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379093002/40001
5 years, 2 months ago (2015-10-06 12:44:11 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-06 13:05:18 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 13:05:44 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ff9516b45340e296dfb949f35ea5349deb2744b
Cr-Commit-Position: refs/heads/master@{#31123}

Powered by Google App Engine
This is Rietveld 408576698