AVFoundation NSString*, cache them in the AVFoundationInternal LazyInstance.

AVFoundation NSString*, cache them in the AVFoundationInternal LazyInstance.

Currently there's a symbol retrieval in place every time someone asks for
a NSString* inside the AVFoundation library. Change this so that the
AVFoundationInternal retrieves them on construction and caches them. This
CL should not change the behaviour of the avfoundation_glue.

BUG=323536, 288562
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245132

[mcasas, 2014-01-14 10:18:44]

rsesek@, tommi@ first draft, PTAL.

[tommi (sloooow) - chröme, 2014-01-14 15:08:48]

nice.

https://codereview.chromium.org/137903003/diff/1/media/video/capture/mac/avfo...
File media/video/capture/mac/avfoundation_glue.mm (right):

https://codereview.chromium.org/137903003/diff/1/media/video/capture/mac/avfo...
media/video/capture/mac/avfoundation_glue.mm:32:
AVCaptureDeviceWasConnectedNotification_ = *reinterpret_cast<NSString**>(
There's lot of code duplication here.  What about something like this:

struct {
  NSString** loaded_string;
  const char* symbol;
} av_strings[] = {
  {&AVCaptureDeviceWasConnectedNotification_,
"AVCaptureDeviceWasConnectedNotification"},
  {&AVCaptureDeviceWasDisconnectedNotification_,
"AVCaptureDeviceWasDisconnectedNotification"},
  ... etc ...
};

for (size_t i = 0; i < arraysize(av_strings); ++i) {
  *av_strings[i].loaded_string = *reinterpret_cast<NSString**>(
      dlsym(library_handle_, av_strings[i].symbol));
  DCHECK(*av_strings[i].loaded_string) << dlerror();
}

https://codereview.chromium.org/137903003/diff/1/media/video/capture/mac/avfo...
media/video/capture/mac/avfoundation_glue.mm:115: NSString*
AVCaptureDeviceWasConnectedNotification_;
Since these names don't adhere to the style guide, you could add a comment here
explaining why.

[mcasas, 2014-01-14 16:37:06]

rsesek@, tommi@ please have a look.

[tommi (sloooow) - chröme, 2014-01-14 16:54:00]

lgtm

[Robert Sesek, 2014-01-14 18:42:08]

LGTM

https://codereview.chromium.org/137903003/diff/100001/media/video/capture/mac...
File media/video/capture/mac/avfoundation_glue.mm (right):

https://codereview.chromium.org/137903003/diff/100001/media/video/capture/mac...
media/video/capture/mac/avfoundation_glue.mm:37:
"AVCaptureDeviceWasConnectedNotification"},
nit: for initializers that do not fit on one line, indent 4 spaces more

[commit-bot: I haz the power, 2014-01-15 09:49:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mcasas@chromium.org/137903003/180001

[commit-bot: I haz the power, 2014-01-16 05:13:33]

Change committed as 245132