Files.app: Add a drive sync error event to the fileBrowserPrivate API.

Files.app: Add a drive sync error event to the fileBrowserPrivate API.

Previously no API is provided to report drive sync errors to JavaScript side.
This CL adds the API and colllecs erros by using OperationObserver.

BUG=260510
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245164

[hirono, 2014-01-14 08:53:58]

PTAL the CL? Thanks!

[kinaba, 2014-01-15 02:18:24]

lgtm

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/file_system_observer.h (right):

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/file_system_observer.h:27: // Triggared when a
specific drive error is occured.
nit: s/is occured/occurred/ (no "is" and two "r"s)

[hashimoto, 2014-01-15 07:05:06]

lgtm
sorry for belated response.

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/file_system_observer.h (right):

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/file_system_observer.h:27: // Triggared when a
specific drive error is occured.
On 2014/01/15 02:18:25, kinaba wrote:
> nit: s/is occured/occurred/ (no "is" and two "r"s)

nit: ditto for operation_observer.h.

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right):

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/event_router.cc:574: default:
nit: Having "default" will prevent the compiler from generating errors for
unhandled enums in future.
How about removing this? (If you want to retain NOTREACHED, I guess you can do
the same check by putting DCHECK_NE(DRIVE_SYNC_ERROR_TYPE_NONE, event.type)
before BroadcastEvent?)

[hirono, 2014-01-15 10:40:51]

Thanks!

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/file_system_observer.h (right):

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/file_system_observer.h:27: // Triggared when a
specific drive error is occured.
On 2014/01/15 02:18:25, kinaba wrote:
> nit: s/is occured/occurred/ (no "is" and two "r"s)

Done.

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/exte...
File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right):

https://codereview.chromium.org/137903002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/event_router.cc:574: default:
On 2014/01/15 07:05:06, hashimoto wrote:
> nit: Having "default" will prevent the compiler from generating errors for
> unhandled enums in future.
> How about removing this? (If you want to retain NOTREACHED, I guess you can do
> the same check by putting DCHECK_NE(DRIVE_SYNC_ERROR_TYPE_NONE, event.type)
> before BroadcastEvent?)

Done.

[commit-bot: I haz the power, 2014-01-15 12:57:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/137903002/110001

[commit-bot: I haz the power, 2014-01-15 16:44:40]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[hirono, 2014-01-15 17:11:01]

@benwells - PTAL file_browser_private.idl? Thanks!

[benwells, 2014-01-15 22:38:50]

Just a question which you should feel free to ignore.

lgtm.

https://codereview.chromium.org/137903002/diff/110001/chrome/common/extension...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/137903002/diff/110001/chrome/common/extension...
chrome/common/extensions/api/file_browser_private.idl:255: DriveSyncErrorType
type;
Are you envisioning more fields here? Seems like if not, you could just pass the
error type in the onDriveSyncError event.

[hirono, 2014-01-16 02:34:35]

Thanks!

https://codereview.chromium.org/137903002/diff/110001/chrome/common/extension...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/137903002/diff/110001/chrome/common/extension...
chrome/common/extensions/api/file_browser_private.idl:255: DriveSyncErrorType
type;
On 2014/01/15 22:38:50, benwells wrote:
> Are you envisioning more fields here? Seems like if not, you could just pass
the
> error type in the onDriveSyncError event.

Yes, I'm planning add more error types in the future CL, which will use other
properties.
Thanks!

[commit-bot: I haz the power, 2014-01-16 02:36:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/137903002/110001

[commit-bot: I haz the power, 2014-01-16 03:45:41]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-16 03:57:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/137903002/610001

[commit-bot: I haz the power, 2014-01-16 06:17:55]

Change committed as 245164