Chromium Code Reviews Chromium Code Reviews
Issue
1378993003:
Vulcanize new Material Design downloads UI (Closed)
DescriptionVulcanize new Material Design downloads UI
Vulcanize is a resource combiner written in node.js by the Polymer team
(authors CC'd). https://github.com/Polymer/vulcanize
Using it shaves a bit of time off the new MD downloads load time.
It'd be nice to integrate this into our build tooling so that if any
dependent files are modified, vulcanize + crisper would automagically
run. But this would require every Chrome engineer to have node.js + npm
(?) + vulcanize + crisper (a no go at the moment).
I'm going to propose depending on node.js in our build system soon,
but for now simply checking in the vulcanized + crisped output and
requiring folks that work on it to re-run the script (vulcanize.py)
doesn't sound too horrible.
The new way to open the non-vulcanized version is at:
chrome://downloads/dev.html
BUG=526577
R=michaelpg@chromium.org
TBR=phajdan.jr@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/99ce62a76a46f74ee31cd6dd1b28e05d3aafd2fb
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : \o/ #Patch Set 4 : fix warning.svg #Patch Set 5 : readme #Patch Set 6 : node + npm version #Patch Set 7 : license #Patch Set 8 : mo bugs #
Total comments: 6
Patch Set 9 : merge #Patch Set 10 : -crisper.html #Messages
Total messages: 17 (7 generated)
|
