content/renderer/render_view_impl.h - Issue 137893025: Removed unnecessary parameter from didActivateCompositor()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 137893025: Removed unnecessary parameter from didActivateCompositor() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 2d6e498a5ada64379e6e90167f8e0913c90d0388..0bd958164093b4f220e19670224cd1688046327a 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -375,7 +375,12 @@ class CONTENT_EXPORT RenderViewImpl

virtual bool requestPointerLock();

virtual void requestPointerUnlock();

virtual bool isPointerLocked();

+ // FIXME: To be removed as soon as chromium and blink side changes land

+ // didActivateCompositor with parameters is still kept in order to land

+ // these changes s-chromium - https://codereview.chromium.org/137893025/.

+ // s-blink - https://codereview.chromium.org/138523003/

virtual void didActivateCompositor(int input_handler_identifier);

+ virtual void didActivateCompositor() OVERRIDE;

virtual void didHandleGestureEvent(const blink::WebGestureEvent& event,

bool event_cancelled) OVERRIDE;

virtual void initializeLayerTreeView() OVERRIDE;

« no previous file with comments | « AUTHORS ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »