Removed unnecessary parameter from didActivateCompositor()

Removed unnecessary parameter from didActivateCompositor()

The parameter to didActivateCompositor() is not necessary. Hence, removed it. The other blink side changes are here:
https://codereview.chromium.org/138523003/

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256713

[Sunil Ratnu, 2014-01-19 08:03:24]

Please have a look.

[commit-bot: I haz the power, 2014-01-20 05:52:11]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Sunil Ratnu, 2014-01-21 06:30:42]

On 2014/01/20 06:00:46, sunil.ratnu wrote:

These changes have to land first in order to land changes in
https://codereview.chromium.org/138523003/ (Blink Side). 
Please have a look.

[jam, 2014-01-21 07:03:05]

removing myself as a reviewer, jamesr is an owner in content/renderer

[jamesr, 2014-01-21 18:50:34]

https://codereview.chromium.org/137893025/diff/130001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/137893025/diff/130001/AUTHORS#newcode286
AUTHORS:286: Sunil Ratnu <sunil.ratnu@samsung.com>
I don't see this name in our list of CLA signers, either individually or under
Samsung.  Could you check on that on your end?

[Sunil Ratnu, 2014-01-22 05:59:40]

On 2014/01/21 18:50:34, jamesr wrote:
> https://codereview.chromium.org/137893025/diff/130001/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/137893025/diff/130001/AUTHORS#newcode286
> AUTHORS:286: Sunil Ratnu <mailto:sunil.ratnu@samsung.com>
> I don't see this name in our list of CLA signers, either individually or under
> Samsung.  Could you check on that on your end?

Thanks James.
I am having a look at our end. Once its done. I will mention it here.

[Sunil Ratnu, 2014-02-05 05:43:54]

On 2014/01/22 05:59:40, sunil.ratnu wrote:
> On 2014/01/21 18:50:34, jamesr wrote:
> > https://codereview.chromium.org/137893025/diff/130001/AUTHORS
> > File AUTHORS (right):
> > 
> > https://codereview.chromium.org/137893025/diff/130001/AUTHORS#newcode286
> > AUTHORS:286: Sunil Ratnu <mailto:sunil.ratnu@samsung.com>
> > I don't see this name in our list of CLA signers, either individually or
under
> > Samsung.  Could you check on that on your end?
> 
> Thanks James.
> I am having a look at our end. Once its done. I will mention it here.

@jamesr : We have done necessary requirements from our side for CLA. You might
be able to see my name now. Please have a look.

[jamesr, 2014-02-05 20:36:31]

Thank you!  lgtm.  I know the paperwork stuff is annoying but it's sadly
necessary.

[Sunil Ratnu, 2014-02-06 05:14:22]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-02-06 05:16:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/130001

[Sunil Ratnu, 2014-02-06 05:56:05]

The CQ bit was unchecked by sunil.ratnu@samsung.com

[Sunil Ratnu, 2014-02-17 11:43:33]

On 2014/02/06 05:56:05, sunil.ratnu wrote:
> The CQ bit was unchecked by mailto:sunil.ratnu@samsung.com

Hi James,

This patch has corresponding blink side changes at
https://codereview.chromium.org/138523003/.

Both of these patches can not go alone by themselves because of the error
"Derived class hides overloaded virtual function". Can you suggest some way to
merge these changes.

One way that I can think of is to keep the already present method
didActivateCompositor(int) and the new method didActivateCompositor() in base
class. And once these chromium side changes get merged, we can remove
didActivateCompositor(int) from the base class.

Thanks!

[jamesr, 2014-02-18 22:16:43]

On 2014/02/17 11:43:33, sunil.ratnu wrote:
> On 2014/02/06 05:56:05, sunil.ratnu wrote:
> > The CQ bit was unchecked by mailto:sunil.ratnu@samsung.com
> 
> Hi James,
> 
> This patch has corresponding blink side changes at
> https://codereview.chromium.org/138523003/.
> 
> Both of these patches can not go alone by themselves because of the error
> "Derived class hides overloaded virtual function". Can you suggest some way to
> merge these changes.
> 

Ah, bummer!

> One way that I can think of is to keep the already present method
> didActivateCompositor(int) and the new method didActivateCompositor() in base
> class. And once these chromium side changes get merged, we can remove
> didActivateCompositor(int) from the base class.
> 

Yes - this sounds like a way to go about it.  Implement both versions on the
chromium side, then switch the blink side over to call the new version, then
delete the old one.

> Thanks!

[Sunil Ratnu, 2014-02-19 07:52:10]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-02-19 07:52:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/520001

[commit-bot: I haz the power, 2014-02-19 07:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 07:55:39]

Try jobs failed on following builders: mac_chromium_rel

[Sunil Ratnu, 2014-02-19 08:34:32]

The CQ bit was unchecked by sunil.ratnu@samsung.com

[Sunil Ratnu, 2014-02-20 05:54:01]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-02-20 08:39:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/520001

[Sunil Ratnu, 2014-02-20 09:33:37]

The CQ bit was unchecked by sunil.ratnu@samsung.com

[Sunil Ratnu, 2014-02-20 09:38:26]

On 2014/02/20 08:39:21, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>
https://chromium-status.appspot.com/cq/sunil.ratnu%40samsung.com/137893025/52...

@James,

Now Keeping both versions of the function in this patch. Once it lands, then
blink patch can be landed with corresponding new changes and then older version
of the function can be removed from chromium side.
I suppose commit bot expects one more approval since a lot of changes have been
done after the previous lgtm.

Does these look fine to you? PTAL.

[jamesr, 2014-02-20 23:51:20]

On 2014/02/20 09:38:26, sunil.ratnu wrote:
> On 2014/02/20 08:39:21, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >
>
https://chromium-status.appspot.com/cq/sunil.ratnu%2540samsung.com/137893025/...
> 
> @James,
> 
> Now Keeping both versions of the function in this patch. Once it lands, then
> blink patch can be landed with corresponding new changes and then older
version
> of the function can be removed from chromium side.
> I suppose commit bot expects one more approval since a lot of changes have
been
> done after the previous lgtm.
> 
> Does these look fine to you? PTAL.

The change that added your name to the AUTHORS file got dropped at some point,
so the bot is unhappy.  Could you add that back?

[Sunil Ratnu, 2014-02-21 06:39:50]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-02-21 06:40:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/720001

[commit-bot: I haz the power, 2014-02-21 07:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 07:11:18]

Try jobs failed on following builders: mac_chromium_rel

[Sunil Ratnu, 2014-02-26 07:03:40]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-02-26 07:06:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/1000001

[commit-bot: I haz the power, 2014-02-26 07:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-26 07:06:23]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 308.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
e5625de5b6f7fd1051caf7c10feb0c4f9a2ea55e..082d7946324fac652e400dd62629b310726a8fd4
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -308,6 +308,7 @@ Sudarsana Babu Nagineni <sudarsana.nagineni@intel.com>
 Sudarshan Parthasarathy <sudarshan.p@samsung.com>
 Sungguk Lim <limasdf@gmail.com>
 Sungmann Cho <sungmann.cho@gmail.com>
+Sunil Ratnu <sunil.ratnu@samsung.com>
 Sylvain Zimmer <sylvinus@gmail.com>
 Szymon Piechowicz <szymonpiechowicz@o2.pl>
 Takeshi Kurosawa <taken.spc@gmail.com>

[Sunil Ratnu, 2014-02-26 07:16:11]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-02-26 07:21:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/1020001

[Sunil Ratnu, 2014-02-26 08:23:56]

The CQ bit was unchecked by sunil.ratnu@samsung.com

[Sunil Ratnu, 2014-03-11 15:00:46]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-03-11 15:04:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/1040001

[commit-bot: I haz the power, 2014-03-11 15:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 15:07:13]

Internal error: failed to checkout. Please try again.

[Sunil Ratnu, 2014-03-11 15:35:58]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-03-11 15:38:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/1040001

[commit-bot: I haz the power, 2014-03-11 15:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 15:58:18]

Try jobs failed on following builders: mac_chromium_compile_dbg,
mac_chromium_rel

[Sunil Ratnu, 2014-03-11 16:17:13]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-03-11 16:19:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/1040001

[commit-bot: I haz the power, 2014-03-11 16:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 16:41:12]

Try jobs failed on following builders: mac_chromium_rel

[Sunil Ratnu, 2014-03-12 10:12:45]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-03-12 10:14:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/1040001

[commit-bot: I haz the power, 2014-03-12 11:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 11:43:28]

Retried try job too often on win_rel for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Sunil Ratnu, 2014-03-12 19:21:52]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-03-12 19:43:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137893025/1040001

[commit-bot: I haz the power, 2014-03-13 00:40:04]

Change committed as 256713