Issue 137893014: Back out trunk r245028

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137893014: Back out trunk r245028 (Closed)

Created:
6 years, 11 months ago by Mark Mentovai

Modified:
6 years, 11 months ago

Reviewers:
danakj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Back out trunk r245028 It seems to have cuased bug 335108 and XP Tests 1 interactive_ui_tests BookmarkBarViewTest18.BookmarkBarViewTest18_SiblingMenu http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/29747 > aura: Destroy the compositor before destroying the backing window. > > This was causing linux_aura single-process browser tests to crash since > they don't set up a default X error handler. When the compositor is > shutting down it does a finish and this might try to swap to the X > window. > > Also change the windows shutdown ordering to match. > > R=ben, enne > BUG=270918 > > Review URL: https://codereview.chromium.org/132473007 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245215

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+4 lines, -17 lines)			Patch
trunk/src/ui/aura/window_tree_host.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
trunk/src/ui/gfx/win/window_impl.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_win.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r245215.