[Password Autofill] Catch XHR submitted forms where onsubmit() wasn't called.

chrome/browser/password_manager/password_manager_browsertest.cc

Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index db3c84ce1e9b286564480ffa913d4c70c411068a..fe9af2d7a1162234a255df777967504987b80d41 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -300,14 +300,12 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
   EXPECT_TRUE(observer.infobar_shown());
 }
 
-IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, NoPromptForOtherXHR) {
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       PromptForXHRWithoutOnSubmit) {
   NavigateToFile("/password/password_xhr_submit.html");
 
-  // Verify that if random XHR navigation occurs, we don't try and save the
-  // password.
-  //
-  // We may want to change this functionality in the future to account for
-  // cases where the element that users click on isn't a submit button.
+  // Verify that if XHR navigation and the form is properly filled out, we

[vabr (Chromium), 2014/01/16 09:22:10]

nit: The sentence "if XHR navigation" seems to lack the verb.

[Garrett Casto, 2014/01/16 22:23:59]

Done.

+  // try and save the password even though onsubmit hasn't been called.
   NavigationObserver observer(WebContents());
   std::string fill_and_navigate =
       "document.getElementById('username_field').value = 'temp';"
@@ -315,7 +313,18 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, NoPromptForOtherXHR) {
       "send_xhr()";
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_navigate));
   observer.Wait();
-  EXPECT_FALSE(observer.infobar_shown());
+  EXPECT_TRUE(observer.infobar_shown());
+}
+
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       NoPromptIfLinkClicked) {
+  NavigateToFile("/password/password_form.html");
+
+  std::string fill_and_click_link =
+      "document.getElementById('username_field').value = 'temp';"
+      "document.getElementById('password_field').value = 'random';"
+      "document.getElementById('link').click();";
+
 }

[vabr (Chromium), 2014/01/16 09:22:10]

Did you forget to check that the prompt does not show?

[Garrett Casto, 2014/01/16 22:23:59]

Whoops, fixed.

 
 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,