Warm up EnumSystemLocalesEx() for Flash Player.

content/ppapi_plugin/ppapi_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/ppapi_plugin/ppapi_thread.h"
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
@@ skipping 34 matching lines @@
 #if defined(OS_WIN)
 #include "base/win/win_util.h"
 #include "base/win/windows_version.h"
 #include "sandbox/win/src/sandbox.h"
 #elif defined(OS_MACOSX)
 #include "content/common/sandbox_init_mac.h"
 #endif
 
 #if defined(OS_WIN)
 extern sandbox::TargetServices* g_target_services;
+// Used by EnumSystemLocalesEx right below for warming up
+static BOOL CALLBACK EnumLocalesProcEx(LPWSTR lpLocaleString, DWORD dwFlags,
+    LPARAM lParam) {
+    return true;
+}
+
+static BOOL CALLBACK EnumLocalesProc(LPTSTR lpLocaleString) {
+    return true;
+}
 #else
 extern void* g_target_services;
 #endif
 
 namespace content {
 
 typedef int32_t (*InitializeBrokerFunc)
     (PP_ConnectInstance_Func* connect_instance_func);
 
 PpapiThread::PpapiThread(const CommandLine& command_line, bool is_broker)
@@ skipping 212 matching lines @@
 #if defined(OS_WIN)
   // If code subsequently tries to exit using abort(), force a crash (since
   // otherwise these would be silent terminations and fly under the radar).
   base::win::SetAbortBehaviorForCrashReporting();
 
   // Once we lower the token the sandbox is locked down and no new modules
   // can be loaded. TODO(cpu): consider changing to the loading style of
   // regular plugins.
   if (g_target_services) {
     // Let Flash load DRM before lockdown on Vista+.
-    if (permissions.HasPermission(ppapi::PERMISSION_FLASH) &&
-        base::win::OSInfo::GetInstance()->version() >=
-        base::win::VERSION_VISTA ) {
-      LoadLibrary(L"dxva2.dll");
+    if (permissions.HasPermission(ppapi::PERMISSION_FLASH)) {
+      if (base::win::OSInfo::GetInstance()->version() >=
+          base::win::VERSION_VISTA ) {
+        LoadLibrary(L"dxva2.dll");
+
+        typedef BOOL (WINAPI *PfnEnumSystemLocalesEx)
+            (LOCALE_ENUMPROCEX, DWORD, LPARAM, LPVOID);
+
+        // Warm up system locales for Vista and above.
+        HMODULE hKernel32Dll = GetModuleHandleW(L"Kernel32.dll");
+        PfnEnumSystemLocalesEx lfpEnumSystemLocalesEx = (PfnEnumSystemLocalesEx)
+            GetProcAddress(hKernel32Dll, "EnumSystemLocalesEx");
+
+        if (lfpEnumSystemLocalesEx)
+            lfpEnumSystemLocalesEx(EnumLocalesProcEx, LOCALE_WINDOWS, 0, 0);
+      } else {
+        typedef BOOL (WINAPI *PfnEnumSystemLocales) (LOCALE_ENUMPROC, DWORD);
+
+        // Warm up system locales for Win XP.
+        HMODULE hKernel32Dll = GetModuleHandleW(L"Kernel32.dll");
+        PfnEnumSystemLocales lfpEnumSystemLocales = (PfnEnumSystemLocales)
+            GetProcAddress(hKernel32Dll, "EnumSystemLocalesW");

[jschuh, 2014/01/15 21:16:01]

EnumSystemLocales is supported in Win2k+, so let the loader handle it rather
than making the explicit GetProcAddress call. Also, if this works to warm up the
system locales, then why can't you call it on the later versions of Windows
rather than explicitly loading and calling EnumSystemLocalesEx? And just to
verify, is the bug present on all supported versions of Windows (WinXP-Win8.1)?

+
+        if (lfpEnumSystemLocales)
+            lfpEnumSystemLocales(EnumLocalesProc, LCID_INSTALLED);
+      }
     }
-
     // Cause advapi32 to load before the sandbox is turned on.
     unsigned int dummy_rand;
     rand_s(&dummy_rand);
     // Warm up language subsystems before the sandbox is turned on.
     ::GetUserDefaultLangID();
     ::GetUserDefaultLCID();
 
     g_target_services->LowerToken();
   }
 #endif
@@ skipping 162 matching lines @@
           histogram_name.str(),
           1,
           LOAD_RESULT_MAX,
           LOAD_RESULT_MAX + 1,
           base::HistogramBase::kUmaTargetedHistogramFlag);
 
   histogram->Add(result);
 }
 
 }  // namespace content