components/offline_pages/offline_page_model.cc - Issue 1378883002: [Offline pages] Selecting pages for clean up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model.cc

Issue 1378883002: [Offline pages] Selecting pages for clean up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating string to clarify intent of the free up space action Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/offline_page_model.cc

diff --git a/components/offline_pages/offline_page_model.cc b/components/offline_pages/offline_page_model.cc

index a3eac9486398fe786dd25e4fe748fb5d0e330972..17e499bde753056e803db37f02ff624147ada661 100644

--- a/components/offline_pages/offline_page_model.cc

+++ b/components/offline_pages/offline_page_model.cc

@@ -180,7 +180,7 @@ const std::vector<OfflinePageItem> OfflinePageModel::GetPagesToCleanUp() const {

std::vector<OfflinePageItem> offline_pages;

base::Time now = base::Time::Now();

for (const auto& id_page_pair : offline_pages_) {

- if (now - id_page_pair.second.creation_time > kPageCleanUpThreshold)

+ if (now - id_page_pair.second.last_access_time > kPageCleanUpThreshold)

offline_pages.push_back(id_page_pair.second);

}

return offline_pages;