Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 137883009: Remove HTMLMediaElement::pageConsentRequiredForLoad() (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove HTMLMediaElement::pageConsentRequiredForLoad() It is unused. BUG=342339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
Patch 3, depends on https://codereview.chromium.org/144663006/
6 years, 10 months ago (2014-02-10 12:54:34 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 10 months ago (2014-02-10 21:55:36 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-11 05:24:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/137883009/1
6 years, 10 months ago (2014-02-11 05:24:20 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 06:22:48 UTC) #5
Message was sent while issue was closed.
Change committed as 166899

Powered by Google App Engine
This is Rietveld 408576698