Issue 137883009: Remove HTMLMediaElement::pageConsentRequiredForLoad()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137883009: Remove HTMLMediaElement::pageConsentRequiredForLoad() (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove HTMLMediaElement::pageConsentRequiredForLoad() It is unused. BUG=342339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166899

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	Source/core/html/HTMLMediaElement.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/html/HTMLMediaElement.cpp	View		2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Patch 3, depends on https://codereview.chromium.org/144663006/

6 years, 10 months ago (2014-02-10 12:54:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/137883009/1

6 years, 10 months ago (2014-02-11 05:24:20 UTC) #4

Message was sent while issue was closed.

Change committed as 166899

Expand Messages | Collapse Messages