Issue 137883002: DevTools: Console object preview should not be lossless if it has accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137883002: DevTools: Console object preview should not be lossless if it has accessors. (Closed)

Created:
6 years, 11 months ago by aandrey

Modified:
6 years, 11 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Console object preview should not be lossless if it has accessors. After expanding an accessor in the preview, the value may not be lossless (e.g. a long truncated string), thus assume such preview not lossless as well. BUG=261470 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165046

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	LayoutTests/inspector/console/console-format-expected.txt	View		3 chunks	+8 lines, -8 lines	0 comments	Download
	M	Source/core/inspector/InjectedScriptSource.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/137883002/1

6 years, 11 months ago (2014-01-14 06:36:11 UTC) #3

Message was sent while issue was closed.

Change committed as 165046

Expand Messages | Collapse Messages