Issue 1378813004: Revert of Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1378813004: Revert of Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) (Closed)

Created:
5 years, 2 months ago by robertphillips

Modified:
5 years, 2 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) (patchset #2 id:20001 of https://codereview.chromium.org/1378023004/ ) Reason for revert: Trial run confirmed layout test expectations - will reland after suppressions Original issue's description: > Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) > > Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db > > Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d8982d7e923d8ab6c7a4ff9456c5ce631ae11423

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/effects/SkBlurMask.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/effects/SkBlurMaskFilter.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

Created Revert of Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor)

5 years, 2 months ago (2015-10-04 19:21:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378813004/1

5 years, 2 months ago (2015-10-04 19:21:27 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-04 19:21:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d8982d7e923d8ab6c7a4ff9456c5ce631ae11423

Expand Messages | Collapse Messages