Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1378793003: X87: Introduce LiteralsArray to hide it's implementation. (Closed)

Created:
5 years, 2 months ago by chunyang.dai
Modified:
5 years, 2 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Introduce LiteralsArray to hide it's implementation. port d8cdd6956a04cfcf03159ef7802c44838eee3146 (r31000). original commit message: The LiteralsArray will soon hold a type feedback vector. Code treats it as an ordinary fixed array, and needs to stop that. BUG= Committed: https://crrev.com/f059762e7402308ee09b7303a688a11fb9445d8f Cr-Commit-Position: refs/heads/master@{#31015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 2 months ago (2015-09-30 03:36:31 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-09-30 05:16:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378793003/1
5 years, 2 months ago (2015-09-30 05:16:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 05:37:34 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 05:37:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f059762e7402308ee09b7303a688a11fb9445d8f
Cr-Commit-Position: refs/heads/master@{#31015}

Powered by Google App Engine
This is Rietveld 408576698