Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1378763006: Fix build - create output dir if needed (Closed)

Created:
5 years, 2 months ago by vsm
Modified:
5 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/codegen_test.dart View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
vsm
Committed patchset #1 (id:1) manually as ed47365eaa6985199555289616b242d2c2878a43 (presubmit successful).
5 years, 2 months ago (2015-10-02 21:23:46 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/1378763006/diff/1/test/codegen_test.dart File test/codegen_test.dart (right): https://codereview.chromium.org/1378763006/diff/1/test/codegen_test.dart#newcode137 test/codegen_test.dart:137: if (!outDir.existsSync()) outDir.createSync(recursive: true); hmm, shouldn't this line do ...
5 years, 2 months ago (2015-10-03 00:23:02 UTC) #2
vsm
On 2015/10/03 00:23:02, John Messerly wrote: > https://codereview.chromium.org/1378763006/diff/1/test/codegen_test.dart > File test/codegen_test.dart (right): > > https://codereview.chromium.org/1378763006/diff/1/test/codegen_test.dart#newcode137 ...
5 years, 2 months ago (2015-10-05 17:40:47 UTC) #3
Jennifer Messerly
5 years, 2 months ago (2015-10-05 17:44:57 UTC) #4
Message was sent while issue was closed.
lgtm then, yeah, hopefully we can sort this out into something cleaner

Powered by Google App Engine
This is Rietveld 408576698