Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1378753002: Stop warnings resulting from unimplemented SetProcessBackgrounded(). (Closed)

Created:
5 years, 2 months ago by shrike
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop warnings resulting from unimplemented SetProcessBackgrounded(). Process::SetProcessBackgrounded() is not implemented on certain platforms (e.g. OS X). Calling Process::SetProcessBackgrounded() on these systems results in a warning to the console. Callers should first check result of Process::CanBackgroundProcesses() before calling SetProcessBackgrounded(). This cl also fixes a small error in the documentation for SetProcessBackgrounded(). BUG=537301 Committed: https://crrev.com/7714401d923571957b492731a107bf0cd761fdde Cr-Commit-Position: refs/heads/master@{#351943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M base/process/process_posix.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/process/process_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
shrike
jam for content, thestig for base. PTAL
5 years, 2 months ago (2015-09-29 21:52:28 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-09-29 21:55:36 UTC) #3
shrike
jam - are you available to take a look at this cl?
5 years, 2 months ago (2015-09-30 22:09:40 UTC) #4
shrike
avi, PTAL (approval for content)
5 years, 2 months ago (2015-10-01 22:44:08 UTC) #6
Avi (use Gerrit)
lgtm
5 years, 2 months ago (2015-10-02 01:04:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378753002/1
5 years, 2 months ago (2015-10-02 01:10:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/115502)
5 years, 2 months ago (2015-10-02 01:20:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378753002/1
5 years, 2 months ago (2015-10-02 01:31:35 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 02:47:10 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 02:47:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7714401d923571957b492731a107bf0cd761fdde
Cr-Commit-Position: refs/heads/master@{#351943}

Powered by Google App Engine
This is Rietveld 408576698