Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1378713004: Issue 24487. Annotations with constructor resolution should produce navigation reginos to construct… (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/24487 Committed: https://github.com/dart-lang/sdk/commit/62fd9ac7878c9f48d0aefdfed8ed7b850375672c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 2 chunks +27 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +107 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-02 17:02:38 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-02 17:34:38 UTC) #2
scheglov
5 years, 2 months ago (2015-10-02 17:45:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
62fd9ac7878c9f48d0aefdfed8ed7b850375672c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698