Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 1378703003: [Samsung Peer Review]Chrome incorrectly honors the 'height' if flex-basis is a percent value

Created:
5 years, 2 months ago by ashlin.j
Modified:
4 years, 6 months ago
Reviewers:
pals, harpreet.sk
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome incorrectly honors the 'height' if flex-basis is a percent value Presently when flex-basis is set as a percentage value and the container length is not specified, the height of the flex-item is taken as auto. Ideally as per spec if the flex-basis is set to 0%, the height should be set to the minimum content height. As per present design when the flex base size for the child is calculated, we see if the main axis length is definite. This length is not definte when flex-basis is auto and when flex-basis is percentage along with the height of the containing block being not specified. The patch modifies the chid size to the content size when the flex-basis is set as percent and main-axis length is indefinte. BUG=531656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378703003/1
4 years, 6 months ago (2016-06-23 11:30:10 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 6 months ago (2016-06-23 11:30:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378703003/1
4 years, 6 months ago (2016-06-23 11:34:21 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 11:35:53 UTC) #9
Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

Powered by Google App Engine
This is Rietveld 408576698