Avoid checks in createElementNS overload

Avoid checks in createElementNS overload

Avoid doing the same qName checks another time by calling createElement directly.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167113

[rwlbuis, 2014-02-12 16:10:16]

A simple patch that avoids some unneeded checks for the custom element
createElementNS overload.

[dominicc (has gone to gerrit), 2014-02-13 04:02:42]

Thanks for working on improvements like this.

https://codereview.chromium.org/137863004/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/137863004/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:773: element = createElement(qName, false);
Could you factor the checks for createElementNS into a separate method? Then
there's less likelihood that those checks would evolve independently. It would
be bad if that were to happen.

[rwlbuis, 2014-02-13 16:12:00]

On 2014/02/13 04:02:42, dominicc wrote:
> Thanks for working on improvements like this.
> 
> https://codereview.chromium.org/137863004/diff/1/Source/core/dom/Document.cpp
> File Source/core/dom/Document.cpp (right):
> 
>
https://codereview.chromium.org/137863004/diff/1/Source/core/dom/Document.cpp...
> Source/core/dom/Document.cpp:773: element = createElement(qName, false);
> Could you factor the checks for createElementNS into a separate method? Then
> there's less likelihood that those checks would evolve independently. It would
> be bad if that were to happen.

Done! It was actually a bit tricky, and likely a bit less efficient because of
copies. OTOH this code path is not used by the html parser.

[gmorrita, 2014-02-13 18:46:45]

LGTM, in behalf of dominicc.

[rwlbuis, 2014-02-13 20:17:21]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-02-13 20:17:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/137863004/80001

[commit-bot: I haz the power, 2014-02-13 21:08:38]

Change committed as 167113