Set Token-Binding HTTP header

net/http/http_stream.h

Index: net/http/http_stream.h
diff --git a/net/http/http_stream.h b/net/http/http_stream.h
index 1febd11ae9526972c51b65502c29a2d933b6df98..757f87b43b12025c07718386874c7a665f5ccc02 100644
--- a/net/http/http_stream.h
+++ b/net/http/http_stream.h
@@ -15,6 +15,7 @@
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
+#include "crypto/ec_private_key.h"

[davidben, 2015/11/18 20:49:00]

Forward decl

[nharper, 2015/12/04 01:42:19]

Done.

 #include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
 #include "net/base/request_priority.h"
@@ -150,6 +151,10 @@ class NET_EXPORT_PRIVATE HttpStream {
   // and does not modify |endpoint| if it is unavailable.
   virtual bool GetRemoteEndpoint(IPEndPoint* endpoint) = 0;
 

[davidben, 2015/11/18 20:49:00]

Documentation?

[nharper, 2015/12/04 01:42:20]

This method is now gone, and a passthru to
SSLClientSocket::GetSignedEKMForTokenBinding added in its place, with
documentation.

+  virtual int GetProvidedTokenBindingWithKey(

[davidben, 2015/11/18 20:49:00]

Nit: Maybe WithKey -> ForKey? Not sure. That seems marginally better. WithKey
sounds like it might return binding + key.

[davidben, 2015/11/18 20:49:00]

So, I'm a little confused about this "provided" vs "referred" business. Since
the signature doesn't include the type anyway (a little bit suspicious in
itself), why not make HttpStream just pass up GetSignedEKMForTokenBinding. We
can wrap it in "provided" outside.

The other motivation is if we push it up as high as assembling the
TokenBindingMessage, we can save an allocation and copy. (Honestly, I'm really
confused what's the point of that too. You can already emit a header multiple
times, so why not use that...)

[nharper, 2015/12/04 01:42:20]

Pushing this up higher did clean up some stuff.

[nharper, 2015/12/04 01:42:20]

Method is gone, so naming is moot.

+      const scoped_ptr<crypto::ECPrivateKey>& key,

[davidben, 2015/11/18 20:49:00]

crypto::ECPrivateKey* is how you spell a non-owning pointer. :-P I'm not sure
const references to scoped_ptr actually make sense.

[nharper, 2015/12/04 01:42:20]

Done.

+      std::string* header_out) = 0;
+
   // In the case of an HTTP error or redirect, flush the response body (usually
   // a simple error or "this page has moved") so that we can re-use the
   // underlying connection. This stream is responsible for deleting itself when