Set Token-Binding HTTP header

net/http/http_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // HttpStream provides an abstraction for a basic http streams, SPDY, and QUIC.
 // The HttpStream subtype is expected to manage the underlying transport
 // appropriately.  For example, a basic http stream will return the transport
 // socket to the pool for reuse.  SPDY streams on the other hand leave the
 // transport socket management to the SpdySession.
 
 #ifndef NET_HTTP_HTTP_STREAM_H_
 #define NET_HTTP_HTTP_STREAM_H_
 
 #include <stdint.h>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
+#include "crypto/ec_private_key.h"

[davidben, 2015/11/18 20:49:00]

Forward decl

[nharper, 2015/12/04 01:42:19]

Done.

 #include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
 #include "net/base/request_priority.h"
 #include "net/base/upload_progress.h"
 
 namespace net {
 
 class BoundNetLog;
 class HttpNetworkSession;
 class HttpRequestHeaders;
@@ skipping 114 matching lines @@
 
   // Get the SSLCertRequestInfo associated with this stream's connection.
   // This should only be called for streams over SSL sockets, otherwise the
   // behavior is undefined.
   virtual void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) = 0;
 
   // Gets the remote endpoint of the socket that the HTTP stream is using, if
   // any. Returns true and fills in |endpoint| if it is available; returns false
   // and does not modify |endpoint| if it is unavailable.
   virtual bool GetRemoteEndpoint(IPEndPoint* endpoint) = 0;
 

[davidben, 2015/11/18 20:49:00]

Documentation?

[nharper, 2015/12/04 01:42:20]

This method is now gone, and a passthru to
SSLClientSocket::GetSignedEKMForTokenBinding added in its place, with
documentation.

+  virtual int GetProvidedTokenBindingWithKey(

[davidben, 2015/11/18 20:49:00]

Nit: Maybe WithKey -> ForKey? Not sure. That seems marginally better. WithKey
sounds like it might return binding + key.

[davidben, 2015/11/18 20:49:00]

So, I'm a little confused about this "provided" vs "referred" business. Since
the signature doesn't include the type anyway (a little bit suspicious in
itself), why not make HttpStream just pass up GetSignedEKMForTokenBinding. We
can wrap it in "provided" outside.

The other motivation is if we push it up as high as assembling the
TokenBindingMessage, we can save an allocation and copy. (Honestly, I'm really
confused what's the point of that too. You can already emit a header multiple
times, so why not use that...)

[nharper, 2015/12/04 01:42:20]

Pushing this up higher did clean up some stuff.

[nharper, 2015/12/04 01:42:20]

Method is gone, so naming is moot.

+      const scoped_ptr<crypto::ECPrivateKey>& key,

[davidben, 2015/11/18 20:49:00]

crypto::ECPrivateKey* is how you spell a non-owning pointer. :-P I'm not sure
const references to scoped_ptr actually make sense.

[nharper, 2015/12/04 01:42:20]

Done.

+      std::string* header_out) = 0;
+
   // In the case of an HTTP error or redirect, flush the response body (usually
   // a simple error or "this page has moved") so that we can re-use the
   // underlying connection. This stream is responsible for deleting itself when
   // draining is complete.
   virtual void Drain(HttpNetworkSession* session) = 0;
 
   // Called when the priority of the parent transaction changes.
   virtual void SetPriority(RequestPriority priority) = 0;
 
   // Queries the UploadDataStream for its progress (bytes sent).
   virtual UploadProgress GetUploadProgress() const = 0;
 
   // Returns a new (not initialized) stream using the same underlying
   // connection and invalidates the old stream - no further methods should be
   // called on the old stream.  The caller should ensure that the response body
   // from the previous request is drained before calling this method.  If the
   // subclass does not support renewing the stream, NULL is returned.
   virtual HttpStream* RenewStreamForAuth() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(HttpStream);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_H_