content/browser/renderer_host/render_widget_host_impl.cc - Issue 1378583003: Unstrangle unhandled key event callback for webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1378583003: Unstrangle unhandled key event callback for webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed variable names and comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index d9b2d6098ab6ecc29744e319dc48f152f97e2e92..172f9e2fd5d0eea38112955e9e014ca251d48977 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -1967,7 +1967,10 @@ void RenderWidgetHostImpl::OnKeyboardEventAck(

// because the user has moved away from us and no longer expect any effect

// of this key event.

const bool processed = (INPUT_EVENT_ACK_STATE_CONSUMED == ack_result);

- if (delegate_ && !processed && !is_hidden() && !event.event.skip_in_browser) {

+ const bool is_composition_key = event.event.nativeKeyCode == 229;

+ if (delegate_ && !processed && !is_hidden() && !event.event.skip_in_browser

+ && !is_composition_key) {

+ LOG(ERROR) << "XXX OnKeyboardEventAck: UnhandledKeyEvent";

delegate_->HandleKeyboardEvent(event.event);

// WARNING: This RenderWidgetHostImpl can be deallocated at this point