Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use UMA without deprecation warnings. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1593ac61faa52e966e6e23b3d7808b92026939b9..a1e7fd0dd919cd3a801dd008295af870e402c5b4 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -49644,6 +49644,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="WebCore.XHR.setRequestHeader.HeaderValueCategoryInRFC7230"
Alexei Svitkine (slow) 2015/09/30 19:44:45 Would it make more sense for this to be Blink.* in
hiroshige 2015/10/01 03:11:52 Done.
+ enum="XMLHttpRequestHeaderValueCategoryInRFC7230">
+ <owner>hiroshige@chromium.org</owner>
+ <summary>
+ The count of XMLHttpRequest.setRequestHeader() calls where header values are
+ invalid/valid but affected by normalization/valid in RFC 7230.
+ https://crbug.com/455099.
+ </summary>
+</histogram>
+
<histogram name="WebFont.BlankTextShownTime" units="milliseconds">
<owner>kenjibaheux@chromium.org</owner>
<owner>ksakamoto@chromium.org</owner>
@@ -73809,6 +73819,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="43" label="Exit"/>
</enum>
+<enum name="XMLHttpRequestHeaderValueCategoryInRFC7230" type="int">
+ <int value="0" label="XMLHttpRequestHeaderValueInvalid"/>
Alexei Svitkine (slow) 2015/09/30 19:44:45 These are human readable, so suggest more easier t
hiroshige 2015/10/01 03:11:52 Done.
+ <int value="1" label="XMLHttpRequestHeaderValueAffectedByNormalization"/>
+ <int value="2" label="XMLHttpRequestHeaderValueValid"/>
+</enum>
+
<enum name="XMLHttpRequestSendArrayBufferOrView" type="int">
<int value="0" label="XMLHttpRequestSendArrayBuffer"/>
<int value="1" label="XMLHttpRequestSendArrayBufferView"/>
« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698