tools/metrics/histograms/histograms.xml - Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reflected comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 1593ac61faa52e966e6e23b3d7808b92026939b9..97e91f552a3641574a993c86cc0c6d50f9199469 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -2783,6 +2783,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Blink.XHR.setRequestHeader.HeaderValueCategoryInRFC7230"

+ enum="XMLHttpRequestHeaderValueCategoryInRFC7230">

+ <owner>hiroshige@chromium.org</owner>

+ <summary>

+ The count of XMLHttpRequest.setRequestHeader() calls where header values are

+ invalid/valid but affected by normalization/valid in RFC 7230.

+ https://crbug.com/455099.

+ </summary>

+</histogram>

<owner>haraken@chromium.org</owner>

<summary>Duration of time taken to run Heap::collectGarbage().</summary>

@@ -73809,6 +73819,12 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="XMLHttpRequestHeaderValueCategoryInRFC7230" type="int">

+ <int value="0" label="Header Value Invalid"/>

+ <int value="1" label="Header Value Affected By Normalization"/>

+ <int value="2" label="Header Value Valid"/>

+</enum>

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | no next file » | no next file with comments »