third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/invalid-octets.html - Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/invalid-octets.html

Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reflected tyoshino's comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/invalid-octets-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-affected-1.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="/js-test-resources/js-test.js"></script>

	3 <script>

	4 window.jsTestIsAsync = true;

	5 description('XMLHttpRequest.setRequestHeader() with control octets ' +

	6 'rejected by RFC 7230 should show a deprecation message.');

	7 // https://crbug.com/455099

	8

	9 var xhr = new XMLHttpRequest;

	10 xhr.open("GET", "../resources/print-headers.cgi");

	11

	12 // '\x01' is invalid in RFC 7230 and thus deprecation warning should be shown.

	13 xhr.setRequestHeader('test1', 'a\x01b');

	14

	15 xhr.onload = function() {

	16 // This expectation must be updated once we update header value checks.

	17 shouldNotBe('xhr.responseText.match(/HTTP_TEST1: a\\x01b\\r?\\n/)',

	18 'null');

	19 finishJSTest();

	20 };

	21 xhr.onerror = function() {

	22 testFailed();

	23 finishJSTest();

	24 };

	25 xhr.send();

	26 </script>

OLD	NEW