third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-unaffected.html - Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-unaffected.html

Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test expectations due to message change. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-affected-1.html ('K') | « third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-affected-3-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-unaffected-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <head>

	3 <script src = "../../resources/testharness.js"></script>

	4 <script src = "../../resources/testharnessreport.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 // Normalization will remove leading/trailing whitespaces, but has no

	9 // effect because the whitespaces are already stripped before the request

	10 // is sent to the network.

	11 // https://fetch.spec.whatwg.org/#concept-header-value-normalize

	12 // https://crbug.com/455099

	13 async_test(function(t) {

	14 var xhr = new XMLHttpRequest;

	15 xhr.open("GET", "../resources/print-headers.cgi");

	16 console.error('This error is added to avoid presubmit errors for -expected.txt with no CONSOLE WARNING. This is testing that no CONSOLE WARNING is shown for s etRequestHeader().');
	tyoshino (SeeGerritForStatus) 2015/09/29 09:02:24 hmm, as the expectation doesn't contain anything b hmm, as the expectation doesn't contain anything but the template output of testharness, can't we just omit the expectation file? hiroshige 2015/09/29 10:34:10 This workaround is removed because the test is mov Show quoted text On 2015/09/29 09:02:24, tyoshino wrote: > hmm, as the expectation doesn't contain anything but the template output of > testharness, can't we just omit the expectation file? This workaround is removed because the test is moved to js-test-based. FYI the answer for the question is No, this test checks NO deprecation warning is output (and if we omit the expectation file we don't check that).
	17

	18 xhr.setRequestHeader('test1', ' a ');

	19 xhr.setRequestHeader('test2', '\ta\t');

	20

	21 xhr.onload = t.step_func(function() {

	22 assert_regexp_match(xhr.responseText, /HTTP_TEST1: a\r?\n/,

	23 'Leading/trailing whitespaces (0x20) are already stripped.');

	24 assert_regexp_match(xhr.responseText, /HTTP_TEST2: a\r?\n/,

	25 'Leading/trailing whitespaces (0x09) are already stripped.');

	26 t.done();

	27 });

	28 xhr.onerror = t.unreached_func('should not fail');

	29 xhr.send();

	30 }, 'single setRequestHeader() with leading/trailing whitespaces');

	31

	32 done();

	33 </script>

	34 </body>

OLD	NEW