third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-affected-1.html - Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-affected-1.html

Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test expectations due to message change. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/invalid-octets.html ('K') | « third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/invalid-octets-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-affected-1-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/header-value-update/normalize-unaffected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <head>

	3 <script src = "../../resources/testharness.js"></script>

	4 <script src = "../../resources/testharnessreport.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 // Normalization will remove leading/trailing whitespaces and has effects
	tyoshino (SeeGerritForStatus) 2015/09/29 09:02:24 Please explain more background. This comment is ha Please explain more background. This comment is hard to understand without background. E.g. According to the spec, normalization (removing leading/trailing whitespaces) must be done on the value argument on setRequestHeader() call. Blink's Fetch API implementation doesn't do that currently but Chromium's network stack is already doing that. So, whether Blink does the normalization or not doesn't have any effect on the data sent to network. But the normalization by Chromium is made on the result of value concatenation by Blink. Blah, Blah, ... hiroshige 2015/09/29 10:34:10 Done. Show quoted text On 2015/09/29 09:02:24, tyoshino wrote: > Please explain more background. This comment is hard to understand without > background. E.g. > > According to the spec, normalization (removing leading/trailing whitespaces) > must be done on the value argument on setRequestHeader() call. Blink's Fetch API > implementation doesn't do that currently but Chromium's network stack is already > doing that. So, whether Blink does the normalization or not doesn't have any > effect on the data sent to network. But the normalization by Chromium is made on > the result of value concatenation by Blink. Blah, Blah, ... Done.
	9 // because the whitespaces remain in the middle of header values as we call

	10 // setRequestHeader multiple times.

	11 // https://fetch.spec.whatwg.org/#concept-header-value-normalize

	12 // https://crbug.com/455099

	13 async_test(function(t) {

	14 var xhr = new XMLHttpRequest;

	15 xhr.open("GET", "../resources/print-headers.cgi");

	16

	17 xhr.setRequestHeader('test1', 'a ');

	18 xhr.setRequestHeader('test1', '\tb');

	19

	20 xhr.onload = t.step_func(function() {

	21 // This expectation must be updated once we update header value checks.

	22 assert_regexp_match(xhr.responseText, /HTTP_TEST1: a , \tb\r?\n/,

	23 'Whitespaces remains in the middle of the header value.');

	24 t.done();

	25 });

	26 xhr.onerror = t.unreached_func('should not fail');

	27 xhr.send();

	28 }, 'multiple setRequestHeader() with leading/trailing whitespaces');

	29

	30 done();
	tyoshino (SeeGerritForStatus) 2015/09/29 09:02:24 is this done() needed? is this done() needed? hiroshige 2015/09/29 10:34:10 Done (moved to js-test) Show quoted text On 2015/09/29 09:02:24, tyoshino wrote: > is this done() needed? Done (moved to js-test)
	31 </script>

	32 </body>

OLD	NEW