Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 137853024: Disable retries when gsutil runs loas_check. (Closed)

Created:
6 years, 11 months ago by dtu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

Disable retries when gsutil runs loas_check. By default, if loasd is not running, loas_check retries twice, waiting 5 seconds between retries. This is in case loasd is restarting due to reinstallation. Unfortunately, if the user has never run prodaccess, this check takes an extra 10 seconds. So, just disable the retries. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/gsutil/plugins/sso_auth.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dtu
6 years, 11 months ago (2014-01-16 23:57:59 UTC) #1
Ken Russell (switch to Gerrit)
For what it's worth, I've run into this. I suspect most Chromium developers who work ...
6 years, 11 months ago (2014-01-17 00:00:48 UTC) #2
M-A Ruel
Wait for Ryan's lgtm but rubberstamp lgtm
6 years, 11 months ago (2014-01-17 00:30:16 UTC) #3
hinoka
lgtm
6 years, 11 months ago (2014-01-17 00:31:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/137853024/1
6 years, 11 months ago (2014-01-17 00:53:31 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 00:55:50 UTC) #6
Message was sent while issue was closed.
Change committed as 245399

Powered by Google App Engine
This is Rietveld 408576698