Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "fake_var_manager.h" | |
| 6 | |
| 7 #include "gtest/gtest.h" | |
| 8 | |
| 9 FakeVarManager::FakeVarManager() : debug(false), next_id_(1) {} | |
| 10 | |
| 11 FakeVarManager::~FakeVarManager() { | |
| 12 // The ref counts for all vars should be zero. | |
| 13 for (VarMap::const_iterator iter = var_map_.begin(); iter != var_map_.end(); | |
| 14 ++iter) { | |
| 15 const FakeVarData& var_data = iter->second; | |
| 16 EXPECT_EQ(0, var_data.ref_count) << "Non-zero refcount on " | |
| 17 << Describe(var_data); | |
| 18 } | |
| 19 } | |
| 20 | |
| 21 FakeVarData* FakeVarManager::CreateVarData() { | |
| 22 Id id = next_id_++; | |
| 23 FakeVarData data; | |
| 24 data.id = id; | |
| 25 data.ref_count = 1; | |
| 26 var_map_[id] = data; | |
| 27 return &var_map_[id]; | |
| 28 } | |
| 29 | |
| 30 void FakeVarManager::AddRef(PP_Var var) { | |
| 31 // From ppb_var.h: | |
| 32 // AddRef() adds a reference to the given var. If this is not a refcounted | |
| 33 // object, this function will do nothing so you can always call it no matter | |
| 34 // what the type. | |
| 35 | |
| 36 FakeVarData* var_data = GetVarData(var); | |
| 37 if (!var_data) | |
| 38 return; | |
| 39 | |
| 40 EXPECT_GT(var_data->ref_count, 0) | |
| 41 << "AddRefing freed " << Describe(*var_data); | |
| 42 var_data->ref_count++; | |
| 43 if (debug) | |
| 44 printf("AddRef of %s [new refcount=%d]\n", | |
| 45 Describe(*var_data).c_str(), | |
| 46 var_data->ref_count); | |
| 47 } | |
| 48 | |
| 49 std::string FakeVarManager::Describe(const FakeVarData& var_data) { | |
| 50 std::stringstream rtn; | |
| 51 switch (var_data.type) { | |
| 52 case PP_VARTYPE_STRING: | |
| 53 rtn << "string resource " << var_data.id << | |
| 54 " with value \"" << var_data.string_value << "\""; | |
| 55 break; | |
| 56 case PP_VARTYPE_ARRAY: | |
| 57 rtn << "array resource with id " << var_data.id; | |
| 58 break; | |
| 59 default: | |
|
binji
2014/01/17 01:31:14
array buffer?
Sam Clegg
2014/01/17 22:40:11
Done.
| |
| 60 rtn << "resource " << var_data.id << " of type " << var_data.type; | |
| 61 break; | |
| 62 } | |
| 63 return rtn.str(); | |
| 64 } | |
| 65 | |
| 66 void FakeVarManager::Destroy(PP_Var var) { | |
| 67 // Release each PP_Var in the array | |
| 68 switch (var.type) { | |
| 69 case PP_VARTYPE_ARRAY: { | |
| 70 std::vector<PP_Var>& vector = GetVarData(var)->array_value; | |
|
binji
2014/01/17 01:31:14
NULL check?
| |
| 71 for (std::vector<PP_Var>::iterator it = vector.begin(); | |
| 72 it != vector.end(); ++it) { | |
| 73 Release(*it); | |
| 74 } | |
| 75 vector.clear(); | |
| 76 break; | |
| 77 } | |
| 78 default: | |
| 79 break; | |
| 80 } | |
| 81 } | |
| 82 | |
| 83 FakeVarData* FakeVarManager::GetVarData(PP_Var var) { | |
| 84 VarMap::iterator iter = var_map_.find(var.value.as_id); | |
| 85 if (iter == var_map_.end()) | |
| 86 return NULL; | |
| 87 return &iter->second; | |
| 88 } | |
| 89 | |
| 90 void FakeVarManager::Release(PP_Var var) { | |
| 91 // From ppb_var.h: | |
| 92 // Release() removes a reference to given var, deleting it if the internal | |
| 93 // reference count becomes 0. If the given var is not a refcounted object, | |
| 94 // this function will do nothing so you can always call it no matter what | |
| 95 // the type. | |
| 96 FakeVarData* var_data = GetVarData(var); | |
| 97 if (!var_data) { | |
| 98 if (debug) | |
| 99 printf("Releasing simple var\n"); | |
| 100 return; | |
| 101 } | |
| 102 | |
| 103 EXPECT_GT(var_data->ref_count, 0) | |
| 104 << "Releasing freed " << Describe(*var_data); | |
| 105 | |
| 106 var_data->ref_count--; | |
| 107 if (debug) | |
| 108 printf("Released %s [new refcount=%d]\n", | |
| 109 Describe(*var_data).c_str(), | |
| 110 var_data->ref_count); | |
| 111 | |
| 112 if (var_data->ref_count == 0) | |
| 113 Destroy(var); | |
|
binji
2014/01/17 01:31:14
erase item in var_map_
Sam Clegg
2014/01/17 22:40:11
I was thinking of leaving the var_map alone until
binji
2014/01/17 22:59:17
OK, sounds good. Maybe add a comment for that?
| |
| 114 } | |
| OLD | NEW |