Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 137853016: Set restrict_to_browser_context parameter for feedback API events (Closed)

Created:
6 years, 11 months ago by tbarzic
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Set restrict_to_browser_context parameter for feedback API events Feedback API is in split mode, so without the parameter, the event may get sent to a wrong profile. BUG=334590 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tbarzic
6 years, 11 months ago (2014-01-16 03:01:34 UTC) #1
rkc
lgtm
6 years, 11 months ago (2014-01-16 03:09:57 UTC) #2
asargent_no_longer_on_chrome
lgtm, sorry for review latency
6 years, 11 months ago (2014-01-17 18:13:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/137853016/1
6 years, 11 months ago (2014-01-17 18:27:10 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 20:02:24 UTC) #5
Message was sent while issue was closed.
Change committed as 245591

Powered by Google App Engine
This is Rietveld 408576698