Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 137853015: Remove more dead code from FrameView (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews
Visibility:
Public.

Description

Remove more dead code from FrameView Remove more dead code from FrameView: - Remove setters for repaint delay static variables as they are never called - Make repaint delay static variables const as they are never updated. We may even be able to remove them completely later on as they are non-zero only if REPAINT_THROTTLING is defined (and it is not). - Remove m_borderX / m_borderX members as they are never used - Remove updateCanHaveScrollbars() method as it is never called - Remove isOverlappedIncludingAncestors() method as it is never called - Remove setAnimatorsAreActive() method as it is never called - Remove beginDeferredRepaints() / endDeferredRepaints() as they are unimplemented - Remove trackedRepaintRects() method as it is never called - Remove isVisuallyNonEmpty() method as it is never called - Remove setLastPaintTime() setter as it is never called R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165191

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -103 lines) Patch
M Source/core/frame/FrameView.h View 1 9 chunks +0 lines, -25 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 6 chunks +8 lines, -78 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
https://codereview.chromium.org/137853015/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/137853015/diff/1/Source/core/frame/FrameView.cpp#newcode95 Source/core/frame/FrameView.cpp:95: #if ENABLE(REPAINT_THROTTLING) Do we want to keep this? This ...
6 years, 11 months ago (2014-01-16 02:13:02 UTC) #1
esprehn
Rslgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 11 months ago (2014-01-16 03:07:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137853015/70001
6 years, 11 months ago (2014-01-16 03:09:10 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 04:03:06 UTC) #4
Message was sent while issue was closed.
Change committed as 165191

Powered by Google App Engine
This is Rietveld 408576698