Issue 137853013: [NaCl SDK] Fix the AppEngine lua build after r243629.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137853013: [NaCl SDK] Fix the AppEngine lua build after r243629. (Closed)

Created:
6 years, 11 months ago by binji

Modified:
6 years, 11 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Fix the AppEngine lua build after r243629. Lua builds using the SDK's common.mk build files, but passes NACL_ARCH=pnacl when building for pnacl. nacl_config.py is now (as of r243629) used in common.mk, but it would error out if toolchain=pnacl, and arch was not unspecified. This change allows toolchain=pnacl, arch=pnacl. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245364

Patch Set 1 #

Patch Set 2 : . #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	native_client_sdk/src/tools/nacl_config.py	View		5 chunks	+8 lines, -4 lines	0 comments	Download
	M	native_client_sdk/src/tools/tests/nacl_config_test.py	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/137853013/30001

6 years, 11 months ago (2014-01-16 18:05:46 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247592

6 years, 11 months ago (2014-01-16 21:57:34 UTC) #4

binji

6 years, 11 months ago (2014-01-16 22:56:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r245364 (presubmit successful).

Expand Messages | Collapse Messages