Speech recognition: Fixing erroneous DCHECK usage

Speech recognition: Fixing erroneous DCHECK usage
When using the legacy API both continuos and provisional_results are
false, and in the JS API they are by default false but can be set to
true independently. The DCHECKs didn't allow for this and erroneously
triggered for some API usages; like the implementation on google.com.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245125

[tommi (sloooow) - chröme, 2014-01-15 15:42:06]

lgtm.

Is there a bug id?  If so, please add it to the description.

https://codereview.chromium.org/137853010/diff/1/content/browser/speech/speec...
File content/browser/speech/speech_recognizer_impl.cc (right):

https://codereview.chromium.org/137853010/diff/1/content/browser/speech/speec...
content/browser/speech/speech_recognizer_impl.cc:691: DCHECK_EQ(true,
provisional_results_);
DCHECK(provisional_results_);

https://codereview.chromium.org/137853010/diff/1/content/browser/speech/speec...
content/browser/speech/speech_recognizer_impl.cc:721: DCHECK_EQ(true,
provisional_results_);
DCHECK(provisional_results_);

[Tommy Widenflycht, 2014-01-15 15:50:15]

https://codereview.chromium.org/137853010/diff/1/content/browser/speech/speec...
File content/browser/speech/speech_recognizer_impl.cc (right):

https://codereview.chromium.org/137853010/diff/1/content/browser/speech/speec...
content/browser/speech/speech_recognizer_impl.cc:691: DCHECK_EQ(true,
provisional_results_);
On 2014/01/15 15:42:07, tommi wrote:
> DCHECK(provisional_results_);

Done.

https://codereview.chromium.org/137853010/diff/1/content/browser/speech/speec...
content/browser/speech/speech_recognizer_impl.cc:721: DCHECK_EQ(true,
provisional_results_);
On 2014/01/15 15:42:07, tommi wrote:
> DCHECK(provisional_results_);

Done.

[commit-bot: I haz the power, 2014-01-15 16:33:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/137853010/70001

[commit-bot: I haz the power, 2014-01-16 05:00:04]

Change committed as 245125