Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137853006: Android: rename DataFetcherImplAndroid -> SensorManagerAndroid. (Closed)

Created:
6 years, 11 months ago by timvolodine
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, timvolodine, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Android: rename DataFetcherImplAndroid -> SensorManagerAndroid. Renamed all occurences of DataFetcherImplAndroid to SensorManagerAndroid to better reflect current implementation of Device Motion/Orientation. Also the relevant tests and files have been renamed in this patch. BUG=334342 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251367

Patch Set 1 #

Patch Set 2 : rebased #

Messages

Total messages: 7 (0 generated)
timvolodine
some refactoring as Marcus suggested some time ago..
6 years, 11 months ago (2014-01-15 16:58:53 UTC) #1
Michael van Ouwerkerk
lgtm
6 years, 11 months ago (2014-01-15 17:02:42 UTC) #2
timvolodine
+piman@ for *.gypi
6 years, 11 months ago (2014-01-16 14:09:26 UTC) #3
piman
lgtm
6 years, 11 months ago (2014-01-16 20:58:01 UTC) #4
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 10 months ago (2014-02-14 16:08:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/137853006/120001
6 years, 10 months ago (2014-02-14 16:08:40 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 17:51:47 UTC) #7
Message was sent while issue was closed. 
Change committed as 251367

Powered by Google App Engine
This is Rietveld 408576698