Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: src/interpreter/bytecode-generator.h

Issue 1378523005: [Interpreter] Add support for global declarations and load/store of global variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_toplevel
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_BYTECODE_GENERATOR_H_ 5 #ifndef V8_INTERPRETER_BYTECODE_GENERATOR_H_
6 #define V8_INTERPRETER_BYTECODE_GENERATOR_H_ 6 #define V8_INTERPRETER_BYTECODE_GENERATOR_H_
7 7
8 #include "src/ast.h" 8 #include "src/ast.h"
9 #include "src/interpreter/bytecode-array-builder.h" 9 #include "src/interpreter/bytecode-array-builder.h"
10 #include "src/interpreter/bytecodes.h" 10 #include "src/interpreter/bytecodes.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 namespace interpreter { 14 namespace interpreter {
15 15
16 class BytecodeGenerator : public AstVisitor { 16 class BytecodeGenerator : public AstVisitor {
17 public: 17 public:
18 BytecodeGenerator(Isolate* isolate, Zone* zone); 18 BytecodeGenerator(Isolate* isolate, Zone* zone);
19 virtual ~BytecodeGenerator(); 19 virtual ~BytecodeGenerator();
20 20
21 Handle<BytecodeArray> MakeBytecode(CompilationInfo* info); 21 Handle<BytecodeArray> MakeBytecode(CompilationInfo* info);
22 22
23 #define DECLARE_VISIT(type) void Visit##type(type* node) override; 23 #define DECLARE_VISIT(type) void Visit##type(type* node) override;
24 AST_NODE_LIST(DECLARE_VISIT) 24 AST_NODE_LIST(DECLARE_VISIT)
25 #undef DECLARE_VISIT 25 #undef DECLARE_VISIT
26 26
27 // Visiting function for declarations list is overridden.
28 void VisitDeclarations(ZoneList<Declaration*>* declarations) override;
29
27 private: 30 private:
28 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS(); 31 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
29 32
30 void VisitArithmeticExpression(BinaryOperation* binop); 33 void VisitArithmeticExpression(BinaryOperation* binop);
31 void VisitPropertyLoad(Register obj, Property* expr); 34 void VisitPropertyLoad(Register obj, Property* expr);
32 void VisitVariableLoad(Variable* variable); 35 void VisitVariableLoad(Variable* variable, FeedbackVectorICSlot slot);
36 void VisitVariableAssignment(Variable* variable, FeedbackVectorICSlot slot);
33 37
34 inline BytecodeArrayBuilder& builder() { return builder_; } 38 inline BytecodeArrayBuilder& builder() { return builder_; }
35 inline Scope* scope() const { return scope_; } 39 inline Scope* scope() const { return scope_; }
36 inline void set_scope(Scope* scope) { scope_ = scope; } 40 inline void set_scope(Scope* scope) { scope_ = scope; }
37 inline CompilationInfo* info() const { return info_; } 41 inline CompilationInfo* info() const { return info_; }
38 inline void set_info(CompilationInfo* info) { info_ = info; } 42 inline void set_info(CompilationInfo* info) { info_ = info; }
43 ZoneVector<Handle<Object>>* globals() { return &globals_; }
39 44
40 LanguageMode language_mode() const; 45 LanguageMode language_mode() const;
41 int feedback_index(FeedbackVectorICSlot slot) const; 46 int feedback_index(FeedbackVectorICSlot slot) const;
47 Register current_context() const;
42 48
43 BytecodeArrayBuilder builder_; 49 BytecodeArrayBuilder builder_;
44 CompilationInfo* info_; 50 CompilationInfo* info_;
45 Scope* scope_; 51 Scope* scope_;
52 ZoneVector<Handle<Object>> globals_;
53
54 // TODO(rmcilroy): Encapsulate this in an environment object.
55 Register current_context_;
46 }; 56 };
47 57
48 } // namespace interpreter 58 } // namespace interpreter
49 } // namespace internal 59 } // namespace internal
50 } // namespace v8 60 } // namespace v8
51 61
52 #endif // V8_INTERPRETER_BYTECODE_GENERATOR_H_ 62 #endif // V8_INTERPRETER_BYTECODE_GENERATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698