[Interpreter] Add support for global declarations and load/store of global variables

[Interpreter] Add support for global declarations and load/store of global variables

Implements support for declaring global variables. Also adds support for loading
from and storing to both global and unallocated global variables.  Adds the
following bytecodes:
 - StoreGlobal
 - LoadContextSlot

BUG=v8:4280
LOG=N

Committed: https://crrev.com/688eacdae9721e877cfe99430bc328bf2f6cf663
Cr-Commit-Position: refs/heads/master@{#31166}

[rmcilroy, 2015-10-01 10:34:14]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 10:34:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378523005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378523005/1

[commit-bot: I haz the power, 2015-10-01 10:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 10:35:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[rmcilroy, 2015-10-01 10:37:25]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, oth@chromium.org, verwaest@chromium.org

[rmcilroy, 2015-10-01 10:37:25]

Michi: Please review the /compiler changes (comments on any other bits also
welcome).

Oth: Please review interpreter changes.

Toon: Feel free to review interpreter changes if you've dug yourself out of your
email mountain ;). Happy to discuss any questions you have about the interpreter
in person or over chat.

Thanks!

[oth, 2015-10-01 12:02:26]

Look fine here. One minor comment.

https://codereview.chromium.org/1378523005/diff/1/src/interpreter/bytecode-ge...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1378523005/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:75: DCHECK(!hole_init);  //
TODO(rmcilroy): Implement hole_init support.
if (!hole_init) UNIMPLEMENTED().

[Michael Starzinger, 2015-10-01 16:08:56]

LGTM from my end.

[rmcilroy, 2015-10-02 14:16:05]

Patchset #2 (id:20001) has been deleted

[rmcilroy, 2015-10-02 14:18:23]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-02 14:18:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378523005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378523005/40001

[commit-bot: I haz the power, 2015-10-02 14:20:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-02 14:20:31]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/8628)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/9233)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/10194)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/10332)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6328)

[rmcilroy, 2015-10-06 14:10:26]

https://codereview.chromium.org/1378523005/diff/1/src/interpreter/bytecode-ge...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1378523005/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:75: DCHECK(!hole_init);  //
TODO(rmcilroy): Implement hole_init support.
On 2015/10/01 12:02:26, oth wrote:
> if (!hole_init) UNIMPLEMENTED(). 

Done.

[oth, 2015-10-06 14:16:33]

On 2015/10/06 14:10:26, rmcilroy wrote:
>
https://codereview.chromium.org/1378523005/diff/1/src/interpreter/bytecode-ge...
> File src/interpreter/bytecode-generator.cc (right):
> 
>
https://codereview.chromium.org/1378523005/diff/1/src/interpreter/bytecode-ge...
> src/interpreter/bytecode-generator.cc:75: DCHECK(!hole_init);  //
> TODO(rmcilroy): Implement hole_init support.
> On 2015/10/01 12:02:26, oth wrote:
> > if (!hole_init) UNIMPLEMENTED(). 
> 
> Done.

lgtm.

[rmcilroy, 2015-10-07 12:27:52]

Toon: Any comments? If you've not got time to look over it now would you be OK
with me landing now and I'll follow up with any suggestions you have?

[Toon Verwaest, 2015-10-07 14:12:20]

the entire global handling is still in flux, but other than that, lgtm.

[rmcilroy, 2015-10-07 17:54:19]

On 2015/10/07 14:12:20, Toon Verwaest wrote:
> the entire global handling is still in flux, but other than that, lgtm.

Thanks Toon. Yeah, I am aware of some of the global handling changes - hopefully
it shouldn't affect this too much but I'm happy to help figure out what's needed
if more tricky changes come up.

[rmcilroy, 2015-10-07 17:54:24]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-10-07 17:54:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, oth@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1378523005/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-07 17:54:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378523005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378523005/80001

[commit-bot: I haz the power, 2015-10-07 17:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-07 17:57:59]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[rmcilroy, 2015-10-07 19:13:45]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-10-07 19:13:45]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mstarzinger@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1378523005/#ps100001
(title: "Rebased again.")

[commit-bot: I haz the power, 2015-10-07 19:13:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378523005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378523005/100001

[commit-bot: I haz the power, 2015-10-07 19:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-07 19:24:46]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/10462)

[rmcilroy, 2015-10-07 20:56:12]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-10-07 20:56:12]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mstarzinger@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1378523005/#ps120001
(title: "Fix test")

[commit-bot: I haz the power, 2015-10-07 20:56:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1378523005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1378523005/120001

[commit-bot: I haz the power, 2015-10-07 21:19:07]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-10-07 21:20:11]

Patchset 6 (id:??) landed as
https://crrev.com/688eacdae9721e877cfe99430bc328bf2f6cf663
Cr-Commit-Position: refs/heads/master@{#31166}