Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1378503003: Suppress scanner errors for non-existent URIs. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress scanner errors for non-existent URIs. Fixes #23754. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/90e975b656c3c0a27d465d8630de9cc3ad8eb947

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-06 17:14:55 UTC) #2
scheglov
lgtm https://codereview.chromium.org/1378503003/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart File pkg/analysis_server/test/analysis/notification_errors_test.dart (right): https://codereview.chromium.org/1378503003/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart#newcode39 pkg/analysis_server/test/analysis/notification_errors_test.dart:39: test_ImportError() { We usually start names with a ...
5 years, 2 months ago (2015-10-06 17:19:09 UTC) #3
pquitslund
Thank you! https://codereview.chromium.org/1378503003/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart File pkg/analysis_server/test/analysis/notification_errors_test.dart (right): https://codereview.chromium.org/1378503003/diff/1/pkg/analysis_server/test/analysis/notification_errors_test.dart#newcode39 pkg/analysis_server/test/analysis/notification_errors_test.dart:39: test_ImportError() { On 2015/10/06 17:19:09, scheglov wrote: ...
5 years, 2 months ago (2015-10-06 17:24:24 UTC) #4
pquitslund
5 years, 2 months ago (2015-10-06 17:25:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
90e975b656c3c0a27d465d8630de9cc3ad8eb947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698