Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1378463004: Another attempt at fixing Win-Clang link error (Closed)

Created:
5 years, 2 months ago by hans
Modified:
5 years, 2 months ago
Reviewers:
yosin
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Another attempt at fixing Win-Clang link error BUG=536963 TBR=yosin Committed: https://chromium.googlesource.com/chromium/src/+/8a68719d2c871cacd4f27b1f5232ada6759fc91e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378463004/1
5 years, 2 months ago (2015-09-29 22:34:41 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/89211) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 2 months ago (2015-09-29 22:44:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378463004/1
5 years, 2 months ago (2015-09-29 22:55:10 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8a68719d2c871cacd4f27b1f5232ada6759fc91e Cr-Commit-Position: refs/heads/master@{#351442}
5 years, 2 months ago (2015-09-29 23:57:14 UTC) #7
hans
5 years, 2 months ago (2015-09-29 23:57:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a68719d2c871cacd4f27b1f5232ada6759fc91e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698