Support serializing ObjectPool as reference.

Support serializing ObjectPool as reference.

Revert to serializing ObjectPool and ICData slots by reference.

Fixes loading precompiled full dart2js snapshot.

Increases size of precompiled.isolate by 3.2%.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/8fac3bf53c11756b11fd202669a5e2c501249597

[rmacnak, 2015-10-01 17:45:24]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-10-01 21:05:09]

lgtm

https://codereview.chromium.org/1378423002/diff/40001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1378423002/diff/40001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:494: NewObjectPool(len) : ObjectPool::New(len));
ObjectPool should only be serialized in a Full snapshot right?

Maybe:

ASSERT(kind_ == Snapshot::kFull);

and just use NewObjectPool(len)

[rmacnak, 2015-10-01 21:32:48]

https://codereview.chromium.org/1378423002/diff/40001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1378423002/diff/40001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:494: NewObjectPool(len) : ObjectPool::New(len));
On 2015/10/01 21:05:09, siva wrote:
> ObjectPool should only be serialized in a Full snapshot right?
> 
> Maybe:
> 
> ASSERT(kind_ == Snapshot::kFull);
> 
> and just use NewObjectPool(len)

Done.

[rmacnak, 2015-10-01 21:33:42]

Committed patchset #4 (id:60001) manually as
8fac3bf53c11756b11fd202669a5e2c501249597 (presubmit successful).