Issue 13784: * Fixed bug in handling of quantified look-aheads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13784: * Fixed bug in handling of quantified look-aheads. (Closed)

Created:
12 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Quantified look-aheads are sometimes removed entirely, leaving only a single atom node. A flag was not set in this case, leading the wrapper code to think the pattern was equal to the atom and use the pattern in the indexOf operation.

Patch Set 1 #

Total comments: 3

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -59 lines)			Patch
M	src/jsregexp.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/jsregexp.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/parser.cc	View	7 chunks	+10 lines, -10 lines	3 comments	Download
M	test/cctest/test-regexp.cc	View	3 chunks	+45 lines, -45 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years ago (2008-12-12 09:52:01 UTC) #2

Lgtm

http://codereview.chromium.org/13784/diff/1/4
File src/parser.cc (right):

http://codereview.chromium.org/13784/diff/1/4#newcode530
Line 530: bool IsNonSimple();
You should generally avoid negative method names.  How about IsSimple()?

http://codereview.chromium.org/13784/diff/1/4#newcode551
Line 551: bool non_simple_;
Ditto.

http://codereview.chromium.org/13784/diff/1/4#newcode3555
Line 3555: bool RegExpParser::IsNonSimple() {
This should be a simple accessor, not a full camel case method.

Expand Messages | Collapse Messages